Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests for packages are failing after beta release #220

Open
gurkanindibay opened this issue Mar 29, 2022 · 2 comments
Open

Tests for packages are failing after beta release #220

gurkanindibay opened this issue Mar 29, 2022 · 2 comments

Comments

@gurkanindibay
Copy link
Contributor

gurkanindibay commented Mar 29, 2022

Getting error while package tests for beta
https://github.com/citusdata/tools/runs/5677881913?check_suite_focus=true

@hanefi
Copy link
Member

hanefi commented Mar 31, 2022

Here is the failure during the following job step:

- name: generate postgres
id: generate-postgres
run: |
export PROJECT_VERSION="${{ github.event.inputs.project_version }}"
echo "project_version: ${{ github.event.inputs.project_version }}"
# To be able to test pipeline without triggering with project_version parameter using workflow_dispatch parameter,
# if workflow_dispatch parameter is empty, 10.2.1 parameter is set to execute pipeline.
[ -z ${PROJECT_VERSION} ] && export PROJECT_VERSION=10.2.1
POSTGRES_VERSIONS=$(python -m packaging_automation.get_postgres_versions --project_version ${PROJECT_VERSION})
echo "Postgres Version: ${POSTGRES_VERSIONS}"
echo "::set-output name=pg_versions::${POSTGRES_VERSIONS}"

The failure output:

project_version: 11.0.0_beta
Traceback (most recent call last):
  File "/usr/lib/python3.8/runpy.py", line 194, in _run_module_as_main
    return _run_code(code, main_globals, None,
  File "/usr/lib/python3.8/runpy.py", line 87, in _run_code
    exec(code, run_globals)
  File "/home/runner/work/tools/tools/packaging_automation/get_postgres_versions.py", line 11, in <module>
    postgres_versions = get_postgres_versions_from_matrix_file(args.project_version)
  File "/home/runner/work/tools/tools/packaging_automation/test_citus_package.py", line 52, in get_postgres_versions_from_matrix_file
    pg_versions = get_supported_postgres_release_versions(POSTGRES_MATRIX_FILE, project_version)
  File "/home/runner/work/tools/tools/packaging_automation/common_tool_methods.py", line 613, in get_supported_postgres_release_versions
    release_versions = match_release_version(versions_dictionary, package_version)
  File "/home/runner/work/tools/tools/packaging_automation/common_tool_methods.py", line 634, in match_release_version
    package_version_numeric = get_numeric_counterpart_of_version(package_version)
  File "/home/runner/work/tools/tools/packaging_automation/common_tool_methods.py", line 662, in get_numeric_counterpart_of_version
    numeric_counterpart = numeric_counterpart + int(num) * multiplier
ValueError: invalid literal for int() with base 10: '0_beta'
Error: Process completed with exit code 1.

@gurkanindibay please include information such as the ones above when opening an issue. Make it easier for the readers to understand what is actually going on.

@hanefi
Copy link
Member

hanefi commented Mar 31, 2022

Apparently get_postgres_versions expects the patch version to be an integer, and not something like 0_beta

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants