Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drops PG14 support #7753

Draft
wants to merge 5 commits into
base: release-13.0
Choose a base branch
from
Draft

Drops PG14 support #7753

wants to merge 5 commits into from

Conversation

naisila
Copy link
Member

@naisila naisila commented Nov 19, 2024

DESCRIPTION: Drops PG14 support

  1. Remove "$version_num" != 'xx' from configure file
  2. delete all PG_VERSION_NUM = PG_VERSION_XX references in the code
  3. Look at pg_version_compat.h file, remove all _compat functions etc defined specifically for PGXX differences
  4. delete all PG_VERSION_NUM >= PG_VERSION_(XX+1), PG_VERSION_NUM < PG_VERSION_(XX+1) ifs in the codebase
  5. delete ruleutils_xx.c file
  6. cleanup normalize.sed file from pg14 specific lines
  7. delete all alternative output files for that particular PG version, server_version_ge variable helps here

Copy link

codecov bot commented Nov 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (release-13.0@b29ecd1). Learn more about missing BASE report.

Additional details and impacted files
@@               Coverage Diff               @@
##             release-13.0    #7753   +/-   ##
===============================================
  Coverage                ?   89.59%           
===============================================
  Files                   ?      274           
  Lines                   ?    59414           
  Branches                ?     7422           
===============================================
  Hits                    ?    53231           
  Misses                  ?     4055           
  Partials                ?     2128           
---- 🚨 Try these New Features:

- Remove "$version_num" != 'xx' from configure file

- delete all PG_VERSION_NUM = PG_VERSION_XX references in the code

- Look at pg_version_compat.h file, remove all _compat functions etc defined specifically for PGXX differences

- delete all PG_VERSION_NUM >= PG_VERSION_(XX+1), PG_VERSION_NUM < PG_VERSION_(XX+1) ifs in the codebase

- delete ruleutils_xx.c file
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant