Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't move map in 3d when in 2dMode on search results. #216

Open
mxfh opened this issue Nov 12, 2024 · 0 comments
Open

Don't move map in 3d when in 2dMode on search results. #216

mxfh opened this issue Nov 12, 2024 · 0 comments
Assignees
Labels
CarmaMap All thing concerning the CarmaMap Component as Wrapper around Cesium + Leaflet Maps in GeoportalMap DX Geoportal LibFuzzySearch

Comments

@mxfh
Copy link
Contributor

mxfh commented Nov 12, 2024

Needs bigger change in architecture of FuzzySearch Lib.

Active Markers and areas should be updated via geoportalMap/CarmaMap State effects, not directly from fuzzy Search to CesiumViewer Instance.

the fuzzysearch lib should not have to care about if map is in 3d or 2d. Also animation control for onSelection should be with the CarmaMap/GeoportalMap.

This would also relief the gazatteer of having to handle anything map related, it only needs to provide the results options.
Handling flyto and marker adding/removal would then be a thing of carmamap itself.

lib fuzzySearch should then have props with callbacks like onResults, onSelection, onClear
could then already add preliminary markers for all options to enable more interactive search behaviour.

decouples LibfuzzySearch from Cesium and Leaflet logic.

@mxfh mxfh self-assigned this Nov 12, 2024
@mxfh mxfh added the CarmaMap All thing concerning the CarmaMap Component as Wrapper around Cesium + Leaflet Maps in GeoportalMap label Nov 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CarmaMap All thing concerning the CarmaMap Component as Wrapper around Cesium + Leaflet Maps in GeoportalMap DX Geoportal LibFuzzySearch
Projects
None yet
Development

No branches or pull requests

1 participant