Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Should this be a fallthrough? #3762

Open
r-barnes opened this issue Jun 20, 2024 · 0 comments
Open

Should this be a fallthrough? #3762

r-barnes opened this issue Jun 20, 2024 · 0 comments

Comments

@r-barnes
Copy link

Can we mark fallthrough's explicit with [[fallthrough]]?

I see an implicit fallthrough here that could be a bug (needs a break) or could be intentional (needs a [[fallthrough]]).

Being consistent about this would allow us to enable -Wimplicit-fallthrough to avoid unintentional mistakes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@r-barnes