Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix import statements for torch in neural model files #415

Closed
vrdn-23 opened this issue Jun 8, 2022 · 0 comments · Fixed by #446
Closed

Fix import statements for torch in neural model files #415

vrdn-23 opened this issue Jun 8, 2022 · 0 comments · Fixed by #446
Assignees
@ritvikshrivastava
Labels
good first issue Good for newcomers refactoring Refactoring code without addition of new features.

Comments

@vrdn-23
Copy link
Contributor

vrdn-23 commented Jun 8, 2022

With the introduction of a PyTorch based CRF (#413), the torch library is now a required dependency for mindmeld. This means we can now clean up the try-except import torch statements found across the neural networks files in Mindmeld.

This was first raised as a comment here.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ritvikshrivastava ritvikshrivastava

Labels
good first issue Good for newcomers refactoring Refactoring code without addition of new features.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

<refactor> remove sklearn crf and update torch checks ritvikshrivastava/mindmeld
2 participants
@ritvikshrivastava @vrdn-23