Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update importing stakeholder function #120

Open
1 task
jeffkause opened this issue May 28, 2024 · 1 comment
Open
1 task

Update importing stakeholder function #120

jeffkause opened this issue May 28, 2024 · 1 comment
Labels
improvement This issue or pull request will add or improve functionality, maintainability, or ease of use

Comments

@jeffkause
Copy link

jeffkause commented May 28, 2024

💡 Summary

To remove the chance of importing private IP addresses into new stakeholder's scope; include coding to search for the private IP addresses and stop the importing of the JSON file into the VS database.

Motivation and context

During the cyhy-ip check command, a warning is displayed to the operator regarding the private IP address(es) found in the request template. If the operator fails to see this warning, they can run the cyhy-import -s cyhy-ops-production-write XXXX.json or cyhy-ip -s cyhy-ops-production-write add commands and import the private IP addresses in the VS database.

This would be useful because to eliminate errors in the VS database and also allow for different checks in the future.

Implementation notes

Current outcomes:

$ cyhy-ip check 192.168.1.1

IPv4 Private: 1

192.168.1.1/32


$ cyhy-import -s cyhy-ops-production-write XXXXXX.json

(No flag)

Requested outcomes:

$ cyhy-ip check 192.168.1.1

IPv4 Private: 1

192.168.1.1/32


$ cyhy-import -s cyhy-ops-production-write XXXXXX.json

Cannot continue! Some addresses already allocated or reserved:
IPv4 Private: 1

192.168.1.1/32


Acceptance criteria

How do we know when this work is done?

  • An attempt to import a private IP address during the onboarding process, displays an error and stops the write to theVS database.
@dav3r dav3r added the improvement This issue or pull request will add or improve functionality, maintainability, or ease of use label May 29, 2024
@KeithBonesJr
Copy link

Please see same issue here @jeffkause cisagov/cyhy-core#61, either close @climber-girl issue or bump it and close this one. My recommendation, is to grab what you need from the other issue and close it and maybe add a comment saying....being tracking here.

@felddy felddy removed this from CyHy Cloud Sep 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement This issue or pull request will add or improve functionality, maintainability, or ease of use
Projects
None yet
Development

No branches or pull requests

3 participants