Added "onbeforeunload" event prompt #98
Conversation
index.js
Outdated
| window.onbeforeunload = function() { | ||
| return ""; | ||
| } |
There was a problem hiding this comment.
This looks like it's unconditionally called on page load? That would interfere with all the other testing use cases, so I think it should be behind a button just like the others.
(Also, would you be able to adjust your editor to avoid formatting the existing code, and avoid any changes in the PR that are not relevant to the new functionality? This will help the PR and project history be easier to review.)
There was a problem hiding this comment.
If we put the code on a button handler then what will be supposed to happen when button clicked.
onbeforeunload event activates for page so that when user closes the tab then a popup occurs. (delayed)
or
popup occurs and if user press ok then window closes. (instant)
There was a problem hiding this comment.
If we put the code on a button handler then what will be supposed to happen when button clicked.
Ah, I should have been a bit more clear. I think the beforeunload handler itself should be registered when the button is pressed. That is, you can click the button and then trigger a navigation if you want to test the beforeunload prompt, but if you don't click the button then the handler is never registered and doesn't interfere with testing other cases.
(On that subject, I would also strongly recommend using window.addEventListener(...) rather than window.onbeforeunload. The sample code from https://developer.mozilla.org/en-US/docs/Web/API/Window/beforeunload_event#examples is probably a good reference.)
RamGoel
force-pushed
the
beforeunload-handler
branch
from
b1e8e44
to
29f41b8
Compare
Prompts only if user has interacted with the webpage. (prompts on closing window and Reloading both)