-
Notifications
You must be signed in to change notification settings - Fork 118
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PWA support #75
Comments
We have an icon at https://github.com/chromium/permission.site/blob/master/app-icon.png that you could use. If we have a service worker, does that preclude using the site over HTTP? The site needs to be accessible over both HTTP and HTTPS for testing. |
+1 to PWA support. It'd be great to see these permission UX flows when viewed in PWA windows as well. Re: HTTP: Would it be possible to have a service worker (and other PWA code) only run when using https? |
That sounds unlikely, but I'm not sure. Any chance you can try to make a demo? |
Oops I'm not too sure how to make a demo like this yet either... Sorry. |
+1 to PWA support. There are interesting permissions scenarios to consider when thinking about PWA specific browser features and this tool would really help. AFAIK, service worker source must be served from a https:// URL. The http:// version of this tool would not be installable. The SW would also not work or not be registrable if served from a relative URL to the http:// origin. It's very likely no differences are necessary between the http:// and https:// sites. |
I would love to create a pull request. It's easy! 😉 PWA support is important because some powerful Web APIs like WebUSB API in the foreseeable future can be restricted to only installed web apps. All I need is the app icon in 512x512px resolution. This is one of the PWA criteria. The icon in the highest resolution we now have is 288x288px (https://github.com/chromium/permission.site/blob/master/app-icon.png). @lgarron Do you have the original of the icon? |
Here are my working files, with an export up to 2880px: https://drive.google.com/drive/folders/0B6FmQe6bc6yVYU1uS2l3a2ZETVU?resourcekey=0-JsVOYEKU61l7Khzamdv9XQ&usp=sharing Here's an optimized 512px version: (If you're making a PR, please make sure that the presence of the PWA manifest doesn't automatically prevent access to the HTTP version of the site in the major browsers. Thanks for working on this!) |
Good news! Web push notifications are available for web apps on iOS and iPadOS since version 16.4 beta 1 (official announcement: https://webkit.org/blog/13878/web-push-for-web-apps-on-ios-and-ipados/), but web app must be installed to home screen. So I prioritize this feature in my backlog. :) I should also add a note that notifications require PWA installation to work on iOS. |
Would the team be interested in a PR that adds enough support for this site to meet Chrome's PWA installability bar? This would entail an app manifest with icons, and a service worker.
The text was updated successfully, but these errors were encountered: