Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve lint rule help #2278

Open
IEncinas10 opened this issue Oct 6, 2024 · 2 comments
Open

Improve lint rule help #2278

IEncinas10 opened this issue Oct 6, 2024 · 2 comments
Assignees
Labels
enhancement New feature or request good first issue Good for newcomers style-linter Verilog style-linter issues

Comments

@IEncinas10
Copy link
Collaborator

IEncinas10 commented Oct 6, 2024

Summary

Rule descriptions can be obtained by running verible-verilog-lint --help_rules=all, which is
not properly formatted for long descriptions. It also doesn't support showing examples, which might be useful for some complex rules. Current workaround is reading the source code and tests for a rule, which is not all that great.

Proposal

  1. Fixing formatting for very long descriptions shouldn't be hard. Easiest solution is to break description strings with newlines and indentation after a certain threshold is past.
  2. We might want to add an extra-verbose mode where rule help prints a few examples for a given rule.

If anyone wants to take this / ask for pointers, go ahead. A few tips for potential contributors unfamiliar with the tool / bazel build system.

  1. bazel build //verilog/tools/lint:verible-verilog-lint compiles the CLI lint tool, which will be available at ./bazel-bin/verilog/tools/lint/verible-verilog-lint
  2. verible-verilog-lint --help_rules=all / verible-verilog-lint --help_rules=<RULE_NAME>should print rules' help message.

Relevant snippets of code:

@IEncinas10 IEncinas10 added enhancement New feature or request style-linter Verilog style-linter issues good first issue Good for newcomers labels Oct 6, 2024
@batmnnn
Copy link

batmnnn commented Nov 9, 2024

can you assign this issue to me ? i'm able to do the first part of proposal , will need some help in second @IEncinas10

@IEncinas10
Copy link
Collaborator Author

Sure! They don't have to be completed in the same PR, just part 1) would be great.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers style-linter Verilog style-linter issues
Projects
None yet
Development

No branches or pull requests

2 participants