local does not skip functional when commented out

[lordkage]

I have delivery installed via chef-dk with the following versions:

Chef Development Kit Version: 2.3.4
delivery version: master (73ebb72a6c42b3d2ff5370c476be800fee7e5427)

It is my understanding, that if the functional phase is commented out then delivery will skip it. However, when running one of the roll-up commands, it still attempts to run the functional phase resulting in this error:

Unable to execute an empty phase.
Please verify that your project.toml has a functional phase configured as follows:

[local_phases]
functional = "insert script here"
Phase failed with exit code (1)!

I built the cookbook with the generate command, so chef was kind enough to autogenerate both the project.toml and the config.json files. The autogenerated project.toml file contains the functional phase commented out. I attempted to add functional to the skip_phases in the config.json, unfortunately, this did not cause delivery to skip the phase.

What else am I missing? Or is this a legitimate bug?

[darko-mesaros]

I am also facing this issue. After the Smoke phase I get the following:

Unable to execute an empty phase.
Please verify that your project.toml has a functional phase configured as follows:

[local_phases]
functional = "insert script here"
Phase failed with exit code (1)!

My project.toml looks like so:

[local_phases]
unit = "rspec spec/"
lint = "cookstyle"
syntax = "foodcritic . -f correctness"
provision = "chef exec kitchen create"
deploy = "chef exec kitchen converge"
smoke = "chef exec kitchen verify"
cleanup = "chef exec kitchen destroy"

I've tried to remove the last two lines - but it still fails the same.

[darko-mesaros]

I've made this "work"!
By adding just a dummy functional phase:

functional = "echo ==dummy test please ignore=="

[lordkage]

I put a similar work around in place on my cookbook.

However, I would prefer to have the phase skipped if it is omitted, like the documentation indicates. Seeing chef autogenerates defaults are commented out. Or at the least, provide an example script that runs by default.

[lordkage]

Several versions have been released. No progress? This seems like a core item that is broken, or at the least, divergent from your documented behavior.

[lordkage]

I just installed the latest chef-dk and comment out my dummy functional test, and the result is still the same.

[lordkage]

Ok. So, syntax is now deprecated, and it suffers from same problem. Any word on this?