-
Notifications
You must be signed in to change notification settings - Fork 327
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: VuePress to VitePress #809
base: master
Are you sure you want to change the base?
Conversation
By nature, the move from VuePress -> VitePress should also allow us to drop the babel dependencies too, right? A very brief peek at the source suggests it is not used outside of VuePress. |
I tested it on your branch and |
You should be able to remove chartjs-plugin-zoom/docs/.vuepress/config.js Lines 89 to 90 in bfd207d
|
Great! If #808 gets merged there won't be two versions of Rollup and related plugins further reducing the count. |
Hammer is needed by the zoom plugin, and ng-hammerjs can be used as replacemend (it does not require window). |
I did not have time to take a look at this yet, but I'm game getting rid of VuePress. |
Yes, hammer.js is still needed, but ng-hammerjs was only used for VuePress, as it appeared, so I was suggesting the move to VitePress could remove ng-hammerjs. I'm not suggesting to remove hammer entirely. |
Good to know there is interest in this! I will have to take another look at it, because some things have changed in the meantime (VitePress 1.0, ...). |
@kurkle does it mean we will migrate the other plugins (i.e. annotation) too? I personally agree with that because many of security alerts are coming from a Vuepress version. |
Hopefully 😅 |
@kurkle fine! I'll open a task in the annotation as soon as I can ;) |
This reduces the number of dev dependencies by about 700.
Towards #812