Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: VuePress to VitePress #809

Draft
wants to merge 6 commits into
base: master
Choose a base branch
from
Draft

Conversation

bavoco
Copy link
Contributor

@bavoco bavoco commented Mar 11, 2024

This reduces the number of dev dependencies by about 700.

Towards #812

@bavoco bavoco marked this pull request as draft March 11, 2024 22:18
@bavoco bavoco mentioned this pull request Mar 17, 2024
4 tasks
@bavoco bavoco marked this pull request as ready for review March 17, 2024 19:59
@NotTsunami
Copy link

By nature, the move from VuePress -> VitePress should also allow us to drop the babel dependencies too, right? A very brief peek at the source suggests it is not used outside of VuePress.

@NotTsunami
Copy link

I tested it on your branch and npm run docs passes with the babel dependencies removed. With @babel/core, @babel/preset-env, and babel-loader removed, another 155 packages are removed. npm run test passes with 76/76 tests while npm run lint and npm run build complete without error.

@NotTsunami
Copy link

NotTsunami commented Apr 10, 2024

You should be able to remove ng-hammerjs as well, since it was only used in VuePress:

// Hammerjs requires window, using ng-hammerjs instead
'hammerjs': 'ng-hammerjs',

@bavoco
Copy link
Contributor Author

bavoco commented Apr 11, 2024

Great! If #808 gets merged there won't be two versions of Rollup and related plugins further reducing the count.

@kurkle
Copy link
Member

kurkle commented Nov 17, 2024

You should be able to remove ng-hammerjs as well, since it was only used in VuePress:

// Hammerjs requires window, using ng-hammerjs instead
'hammerjs': 'ng-hammerjs',

Hammer is needed by the zoom plugin, and ng-hammerjs can be used as replacemend (it does not require window).
So I don't think that can be removed (until this plugin gets rid of the dependency)

@kurkle
Copy link
Member

kurkle commented Nov 17, 2024

I did not have time to take a look at this yet, but I'm game getting rid of VuePress.

@NotTsunami
Copy link

You should be able to remove ng-hammerjs as well, since it was only used in VuePress:

// Hammerjs requires window, using ng-hammerjs instead
'hammerjs': 'ng-hammerjs',

Hammer is needed by the zoom plugin, and ng-hammerjs can be used as replacemend (it does not require window). So I don't think that can be removed (until this plugin gets rid of the dependency)

Yes, hammer.js is still needed, but ng-hammerjs was only used for VuePress, as it appeared, so I was suggesting the move to VitePress could remove ng-hammerjs. I'm not suggesting to remove hammer entirely.

@bavoco
Copy link
Contributor Author

bavoco commented Nov 18, 2024

Good to know there is interest in this! I will have to take another look at it, because some things have changed in the meantime (VitePress 1.0, ...).

@bavoco bavoco marked this pull request as draft November 18, 2024 11:07
@stockiNail
Copy link
Contributor

I did not have time to take a look at this yet, but I'm game getting rid of VuePress.

@kurkle does it mean we will migrate the other plugins (i.e. annotation) too? I personally agree with that because many of security alerts are coming from a Vuepress version.

@kurkle
Copy link
Member

kurkle commented Nov 19, 2024

@kurkle does it mean we will migrate the other plugins (i.e. annotation) too? I personally agree with that because many of security alerts are coming from a Vuepress version.

Hopefully 😅

@stockiNail
Copy link
Contributor

@kurkle fine! I'll open a task in the annotation as soon as I can ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants