Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a config option to enable/disable git, http and stats #594

Open
bw9ubwo opened this issue Nov 8, 2024 · 0 comments
Open

Add a config option to enable/disable git, http and stats #594

bw9ubwo opened this issue Nov 8, 2024 · 0 comments
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@bw9ubwo
Copy link

bw9ubwo commented Nov 8, 2024

I think it is a good Idea to add an config option to disable/enable services like git, http and stats if the user doesn't need them. Specially, the Prometheus part has nothing to do with the main functionality.

I discussed this already here:
#590
@aymanbagabas aymanbagabas added enhancement New feature or request good first issue Good for newcomers labels Nov 8, 2024
jaw pushed a commit to jaw/soft-serve that referenced this issue Nov 14, 2024
feat: config supports toggling HTTP and Stats servers on/off (charmbr…
0e67bc9 
…acelet#594)
jaw pushed a commit to jaw/soft-serve that referenced this issue Nov 14, 2024
feat: config supports toggling HTTP and Stats servers on/off (charmbr…
f50513b 
…acelet#594)
jaw pushed a commit to jaw/soft-serve that referenced this issue Nov 14, 2024
feat: config supports toggling HTTP and Stats servers on/off (charmbr…
4517e6f 
…acelet#594)
jaw pushed a commit to jaw/soft-serve that referenced this issue Nov 14, 2024
feat: config supports toggling HTTP and Stats servers on/off (charmbr…
9df0211 
…acelet#594)
jaw pushed a commit to jaw/soft-serve that referenced this issue Nov 14, 2024
feat: config supports toggling HTTP and Stats servers on/off (charmbr…
45494f5 
…acelet#594)
jaw pushed a commit to jaw/soft-serve that referenced this issue Nov 18, 2024
feat: config supports toggling HTTP and Stats servers on/off (charmbr…
106f2d0 
…acelet#594)
jaw pushed a commit to jaw/soft-serve that referenced this issue Nov 19, 2024
feat: support toggling servers on/off in configuration (charmbracelet…
980acf4 
…#594)

This also fixes a bug in the git daemon which would listen on TCP as it was created.
Now it only listens when Start() has been called.
To facilitate testing of this, tests now use the more granular

  `ensureserverrunning [SERVICE_NAME]` instead of the

previous, more crude `waitforserver`.
jaw pushed a commit to jaw/soft-serve that referenced this issue Nov 21, 2024
feat: support toggling servers on/off in configuration (charmbracelet…
2c506f4 
…#594)

To test this, tests added:

  `ensureservernotrunning [SERVICE_NAME]`
jaw pushed a commit to jaw/soft-serve that referenced this issue Nov 21, 2024
feat: support toggling servers on/off in configuration (charmbracelet…
bdd80c2 
…#594)

To test this, tests added:

  `ensureservernotrunning [SERVICE_NAME]`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@bw9ubwo @aymanbagabas