Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Major version bump where minor is set #358

Open
wallwhite opened this issue Mar 21, 2024 · 1 comment
Open

Major version bump where minor is set #358

wallwhite opened this issue Mar 21, 2024 · 1 comment

Comments

@wallwhite
Copy link

Recently, we faced the issue with versioning for the second time and decided to create this issue. I've tried to find some solutions or answers why it happens but didn't found anything helpful.

In our project we have a bunch of fixed packages to have consistency when something has changed.
Here is how our config looks:

{
  "$schema": "https://unpkg.com/@changesets/[email protected]/schema.json",
  "changelog": "@changesets/cli/changelog",
  "commit": false,
  "fixed": [[
    "@organization/anchor",
    "@organization/badge",
    "@organization/button",
    "@organization/container",
    "@organization/divider",
    "@organization/form",
    "@organization/heading",
    "@organization/hint",
    "@organization/icon-container",
    "@organization/icons",
    "@organization/inputs",
    "@organization/stack",
    "@organization/tag",
    "@organization/text",
    "@organization/theme",
    "@organization/react-core"
  ]],
  "linked": [],
  "access": "restricted",
  "baseBranch": "develop",
  "updateInternalDependencies": "patch",
  "ignore": [
    "@organization/react-storybook"
  ]
}

And here is the latest generated changeset md file:

---
"@organization/anchor": minor
"@organization/badge": minor
"@organization/button": minor
"@organization/container": minor
"@organization/divider": minor
"@organization/form": minor
"@organization/heading": minor
"@organization/hint": minor
"@organization/icon-container": minor
"@organization/icons": minor
"@organization/inputs": minor
"@organization/stack": minor
"@organization/tag": minor
"@organization/text": minor
"@organization/react-core": minor
"@organization/theme": minor
"@organization/vite-config-package": minor
"@organization/eslint-config": minor
"@organization/eslint-config-legacy": minor
"@organization/stylelint-config": minor
"@organization/ts-config": minor
---

Release note...

From the first sight, everything looks nice.

The previous versions of our packages was next:

  • @organization/anchor - 1.0.0
  • ...
  • @organization/react-core - 1.0.3
  • @organization/theme - 1.0.3
  • @organization/vite-config-package - 1.1.0
  • @organization/eslint-config - 1.2.0
  • @organization/eslint-config-legacy - 1.1.0
  • @organization/stylelint-config - 1.2.0
  • @organization/ts-config - 1.1.0

When the "github action" had been completed we've seen that most of our packages' versions was bumped to next major version instead of minor.
The major version was applied to the all components' packages but not for system configs. Looks like the issue is related to fixed version functionality.

@vicary
Copy link

vicary commented Jul 18, 2024

I think we are experiencing a similar issue at #381, our patch changes are released as major changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants