-
Notifications
You must be signed in to change notification settings - Fork 296
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Needed in the IDF (intelmq data format): severity #2365
Comments
The criticality of an event depends not only on the type of event defined by the feed provider but also on criteria known to the IntelMQ operator, such as which network the device is in. How much will the |
P.S.: We normally follow semantic versioning, so 3.1.1 (the milestone you selected for this issue) is a patch/bugfix release. IMHO a newly added field is not a patch. |
It is embedded in a bigger discussion with Shadowserver and should reflect the criticality of the vulnerability as estimated by the source (shadowserver in this case).
So maybe we need to name the proposed field better (such as "source.crticicality" or so?) but that's the idea.
Of course, the recipient will have to define his own criticality but it does convey something if the source says it's critical (for example a RCE).
Shadowserver will add that to all their feeds if I understood them correctly.
And I think that's actually generic enough for all our feeds to have that field here.
… On 24.05.2023, at 13:11, Sebastian ***@***.***> wrote:
The criticality of an event depends not only on the type of event defined by the feed provider but also on criteria known to the IntelMQ operator, such as which network the device is in.
How much will the criticality be used? Is it worth a new field (involves adapting all outputs on all instances), or is it for extra?
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you were assigned.
|
I think we should get some feedback from users (mailinglist?) as this change has an impact on their setups. |
Shadowserver plans to add a Severity levels:
|
I think it does not impact their setups to have an additional field in the IDF format:
if their bots don't know the field, then nothing will happen.
We however should add a tutorial on how to use that new field for the shadowserver feeds. Because - there it's going to come - for a good reason actually. Based on user feedback (from what I gained from talking to Piotr).
Best,
a.
… On 24.05.2023, at 15:10, Sebastian ***@***.***> wrote:
I think we should get some feedback from users (mailinglist?) as this change has an impact on their setups.
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you were assigned.
|
When an output bot writes data to a database, it does. I think writing data to a database is not uncommon. |
Yes, but having a bot write all fields (without specifically selecting which fields it needs ) to some output DB sounds like a bug at that part, no? Anyways, I got your point. We'll make an IEP008 for that... |
All output bots except the SMTP Output bot write all fields to their destination. Complete list is at https://intelmq.readthedocs.io/en/latest/user/bots.html#output-bots There are some expert bots to remove fields though. The simplest is the Field Reducer Bot. |
On 24.05.2023, at 16:07, Sebastian ***@***.***> wrote:
Yes, but having a bot write all fields (without specifically selecting which fields it needs ) to some output DB sounds like a bug at that part, no?
All output bots except the SMTP Output bot write all fields to their destination. Complete list is at https://intelmq.readthedocs.io/en/latest/user/bots.html#output-bots
There are some expert bots to remove fields though. The simplest is the Field Reducer Bot.
I think we have a problem then with output bots ;-)
It's the equivalent of doing a SELECT * FROM ... and then wondering that you get more fields than you expected hehe.
|
Cross check with @elsif2
The text was updated successfully, but these errors were encountered: