Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expand Volume Health monitoring via VolumeCondition field in CSI RPC of Controller and Node #1356

Closed
1 task
humblec opened this issue Aug 11, 2020 · 19 comments
Closed
1 task

Expand Volume Health monitoring via VolumeCondition field in CSI RPC of Controller and Node #1356

humblec opened this issue Aug 11, 2020 · 19 comments
Labels
component/cephfs Issues related to CephFS component/rbd Issues related to RBD enhancement New feature or request wontfix This will not be worked on

Comments

@humblec
Copy link
Collaborator

humblec commented Aug 11, 2020 •
edited by nixpanic
Loading

Describe the feature you'd like to have

There is an enhancement in NodeGetVolumeStats() which gives provision for us to inform the volume condition of the PV. This is an optional interface and informational message at this moment. However it would be good if we can extend the current interface with this information.

  • nodeGetVolumeStats() can be expanded for volumeCondition field , one simple check here would be checking the state of the mountpoint inside the node
  • Validate the controller capabilties of get/list volume + volume condition field :
  • Implementhing the listVolumes may be costly operation for volume health, however getVolume for volume condition could be used to check the volume exist in the backend or not..etc and populate the response back to the user.

kubernetes/enhancements#1432

Tasks
Beta Give feedback
@humblec humblec self-assigned this Aug 11, 2020
@humblec
Copy link
Collaborator Author

humblec commented Aug 11, 2020

I would like to target this for 3.2.0 release , so adding the milestone.

@humblec humblec added this to the release-3.2.0 milestone Aug 11, 2020
humblec added a commit to humblec/ceph-csi that referenced this issue Aug 13, 2020
@humblec
build: update the CSI Spec to v1.3.0
88ff66f 
This spec add the extra capability to  node and controller
volume to report volume condition of a pv..etc.

Refer # ceph#1356

Signed-off-by: Humble Chirammal <[email protected]>
@humblec humblec mentioned this issue Aug 13, 2020
Merged
ceph-csi-bot pushed a commit to humblec/ceph-csi that referenced this issue Aug 17, 2020
@humblec
build: update the CSI Spec to v1.3.0
05de501 
This spec add the extra capability to  node and controller
volume to report volume condition of a pv..etc.

Refer # ceph#1356

Signed-off-by: Humble Chirammal <[email protected]>
ceph-csi-bot pushed a commit to humblec/ceph-csi that referenced this issue Aug 17, 2020
@humblec
build: update the CSI Spec to v1.3.0
5bc3a19 
This spec add the extra capability to  node and controller
volume to report volume condition of a pv..etc.

Refer # ceph#1356

Signed-off-by: Humble Chirammal <[email protected]>
humblec added a commit to humblec/ceph-csi that referenced this issue Aug 21, 2020
@humblec
build: update the CSI Spec to v1.3.0
f917a08 
This spec add the extra capability to  node and controller
volume to report volume condition of a pv..etc.

Refer # ceph#1356

Signed-off-by: Humble Chirammal <[email protected]>
humblec added a commit to humblec/ceph-csi that referenced this issue Aug 21, 2020
@humblec
build: update the CSI Spec to v1.3.0
284fbb0 
This spec add the extra capability to  node and controller
volume to report volume condition of a pv..etc.

Refer # ceph#1356

Signed-off-by: Humble Chirammal <[email protected]>
humblec added a commit to humblec/ceph-csi that referenced this issue Aug 21, 2020
@humblec
build: update the CSI Spec to v1.3.0
b0775d1 
This spec add the extra capability to  node and controller
volume to report volume condition of a pv..etc.

Refer # ceph#1356

Signed-off-by: Humble Chirammal <[email protected]>
humblec added a commit to humblec/ceph-csi that referenced this issue Aug 25, 2020
@humblec
build: update the CSI Spec to v1.3.0
b0a486a 
This spec add the extra capability to  node and controller
volume to report volume condition of a pv..etc.

Refer # ceph#1356

Signed-off-by: Humble Chirammal <[email protected]>
humblec added a commit to humblec/ceph-csi that referenced this issue Aug 25, 2020
@humblec
build: update the CSI Spec to v1.3.0
3704dee 
This spec add the extra capability to  node and controller
volume to report volume condition of a pv..etc.

Refer # ceph#1356

Signed-off-by: Humble Chirammal <[email protected]>
@nixpanic nixpanic added enhancement New feature or request component/cephfs Issues related to CephFS component/rbd Issues related to RBD labels Aug 25, 2020
humblec added a commit to humblec/ceph-csi that referenced this issue Aug 27, 2020
@humblec
rebase: update the CSI Spec to v1.3.0
e5e8ad0 
This spec add the extra capability to  node and controller
volume to report volume condition of a pv..etc.

Refer # ceph#1356

Signed-off-by: Humble Chirammal <[email protected]>
ceph-csi-bot pushed a commit to humblec/ceph-csi that referenced this issue Sep 4, 2020
@humblec
rebase: update the CSI Spec to v1.3.0
1080818 
This spec add the extra capability to  node and controller
volume to report volume condition of a pv..etc.

Refer # ceph#1356

Signed-off-by: Humble Chirammal <[email protected]>
mergify bot pushed a commit that referenced this issue Sep 4, 2020
@humblec @mergify
rebase: update the CSI Spec to v1.3.0
edca318 
This spec add the extra capability to  node and controller
volume to report volume condition of a pv..etc.

Refer # #1356

Signed-off-by: Humble Chirammal <[email protected]>
@Madhu-1 Madhu-1 modified the milestones: release-3.2.0, release-3.3.0 Dec 8, 2020
@nixpanic nixpanic removed this from the release-3.3.0 milestone Jan 29, 2021
@nixpanic
Copy link
Member

Moving this out of the 3.3 release, as there is no design yet. We will need to know what, and how to safely check for the health of the volumes.

@humblec
Copy link
Collaborator Author

humblec commented Jun 30, 2021

[update] Experimenting on how we can make use of it and hopefully expand this later for wider use cases or automation.

@humblec humblec changed the title Expand NodeGetVolumeStats() response with VolumeCondition field Expand Volume Health monitoring via VolumeCondition field in CSI RPC of Controller and Node Jun 30, 2021
@github-actions
Copy link

github-actions bot commented Sep 5, 2021

This issue has been automatically marked as stale because it has not had recent activity. It will be closed in a week if no further activity occurs. Thank you for your contributions.

@github-actions github-actions bot added the wontfix This will not be worked on label Sep 5, 2021
@github-actions
Copy link

This issue has been automatically closed due to inactivity. Please re-open if this still requires investigation.

@github-actions github-actions bot added the wontfix This will not be worked on label Mar 3, 2022
@github-actions
Copy link

This issue has been automatically closed due to inactivity. Please re-open if this still requires investigation.

@humblec humblec reopened this Mar 11, 2022
@humblec
Copy link
Collaborator Author

humblec commented Mar 11, 2022

I am working on this specifically on Controller SIde Volume Health Monitoring.

@github-actions github-actions bot removed the wontfix This will not be worked on label Mar 11, 2022
@github-actions
Copy link

This issue has been automatically marked as stale because it has not had recent activity. It will be closed in a week if no further activity occurs. Thank you for your contributions.

@github-actions github-actions bot added the wontfix This will not be worked on label Apr 11, 2022
@github-actions
Copy link

This issue has been automatically closed due to inactivity. Please re-open if this still requires investigation.

@humblec humblec reopened this May 25, 2022
@github-actions
Copy link

github-actions bot commented Jun 1, 2022

This issue has been automatically closed due to inactivity. Please re-open if this still requires investigation.

@github-actions github-actions bot closed this as completed Jun 1, 2022
@Madhu-1 Madhu-1 reopened this Sep 13, 2023
@Madhu-1 Madhu-1 removed the wontfix This will not be worked on label Sep 13, 2023
@Madhu-1
Copy link
Collaborator

Madhu-1 commented Sep 13, 2023

@humblec do you still working on this one?

@humblec
Copy link
Collaborator Author

humblec commented Sep 13, 2023

Thanks for checking. not at the moment.. please feel free to reassign..

@Madhu-1 Madhu-1 mentioned this issue Sep 14, 2023
Draft
@github-actions
Copy link

This issue has been automatically marked as stale because it has not had recent activity. It will be closed in a week if no further activity occurs. Thank you for your contributions.

@github-actions github-actions bot added the wontfix This will not be worked on label Oct 14, 2023
@github-actions
Copy link

This issue has been automatically closed due to inactivity. Please re-open if this still requires investigation.

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Oct 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
component/cephfs Issues related to CephFS component/rbd Issues related to RBD enhancement New feature or request wontfix This will not be worked on
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@nixpanic @humblec @Madhu-1