Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add StakingCabin gentx and peer #379

Closed
wants to merge 4 commits into from
Closed

add StakingCabin gentx and peer #379

wants to merge 4 commits into from

Conversation

richard-stakingcabin
Copy link
Contributor

Overview

Checklist

  • New and updated code has appropriate documentation
  • New and updated code has new and/or updated testing
  • Required CI checks are passing
  • Visual proof for any user facing features like CLI or documentation updates
  • Linked issues closed with keywords

Copy link
Member

@liamsi liamsi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you rebase on the latest master please? Or close this and resubmit in a new PR? We made changes to our CI and there have been some fixes.

Copy link
Member

@liamsi liamsi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If I look at the CI output this still looks like it is running an old version:
image

Can you ensure that you use the latest master branch please.

@liamsi
Copy link
Member

liamsi commented Oct 24, 2023

Can you resolve the merge conflicts. I can't do it for you b/c you disabled that maintainers can edit PRs from your fork (which is fine btw).

@richard-stakingcabin
Copy link
Contributor Author

Sorry for any inconvenience I caused. Seems can't enable maintainers edit PRs for repo fork under organization. I fork under my personal account and submit pr again

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants