-
Notifications
You must be signed in to change notification settings - Fork 267
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add CI for validating genesis and PR users #354
Conversation
feat(ci): initialize validation of validator PR user
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
❤️
issue_number: context.issue.number, | ||
owner: context.repo.owner, | ||
repo: context.repo.repo, | ||
body: 'User has previously submitted a gentx PR' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There seems sth off with this. I think we are hitting
networks/.github/workflows/checkuser.go
Lines 48 to 49 in c30aab1
fmt.Println("Fail: User exists with different PR number") | |
return fmt.Errorf("User %s already exists with PR number %s", user, record[1]) |
in https://github.com/celestiaorg/networks/actions/runs/6597322356/job/17924245542?pr=362
But it's hard to say as we don't see any output from that tool.
but it's the only gentx they submitted 🤔
Overview
Example of valid user: #356
Example of invalid user: #355