Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

renaming account ids to aws account ids #1678

Merged
merged 1 commit into from
Nov 27, 2024
Merged

renaming account ids to aws account ids #1678

merged 1 commit into from
Nov 27, 2024

Conversation

ben851
Copy link
Contributor

@ben851 ben851 commented Nov 27, 2024

Summary | Résumé

Rename ENVIRONMENT_ACCOUNT_IDs to ENVIRONMENT_AWS_ACCOUNT_ID

Related Issues | Cartes liées

Before merging this PR

Read code suggestions left by the
cds-ai-codereviewer bot. Address
valid suggestions and shortly write down reasons to not address others. To help
with the classification of the comments, please use these reactions on each of the
comments made by the AI review:

Classification Reaction Emoticon
Useful +1 👍
Noisy eyes 👀
Hallucination confused 😕
Wrong but teachable rocket 🚀
Wrong and incorrect -1 👎

The classifications will be extracted and summarized into an analysis of how helpful
or not the AI code review really is.

Test instructions | Instructions pour tester la modification

TF Apply works

Release Instructions | Instructions pour le déploiement

None.

Reviewer checklist | Liste de vérification du réviseur

  • This PR does not break existing functionality.
  • This PR does not violate GCNotify's privacy policies.
  • This PR does not raise new security concerns. Refer to our GC Notify Risk Register document on our Google drive.
  • This PR does not significantly alter performance.
  • Additional required documentation resulting of these changes is covered (such as the README, setup instructions, a related ADR or the technical documentation).

⚠ If boxes cannot be checked off before merging the PR, they should be moved to the "Release Instructions" section with appropriate steps required to verify before release. For example, changes to celery code may require tests on staging to verify that performance has not been affected.

@ben851 ben851 requested a review from a team November 27, 2024 19:17
Copy link

staging: github

✅   Terraform Init: success
✅   Terraform Validate: success
✅   Terraform Format: success
✅   Terraform Plan: success
✅   Conftest: success

⚠️   Warning: resources will be destroyed by this change!

Plan: 3 to add, 0 to change, 3 to destroy
Show summary
CHANGE NAME
recreate github_actions_secret.account_id
github_actions_secret.api_account_id
github_actions_secret.manifests_account_id
Show plan
Resource actions are indicated with the following symbols:
-/+ destroy and then create replacement

Terraform will perform the following actions:

  # github_actions_secret.account_id must be replaced
-/+ resource "github_actions_secret" "account_id" {
      ~ created_at      = "2024-04-15 18:16:42 +0000 UTC" -> (known after apply)
      ~ id              = "notification-terraform:STAGING_ACCOUNT_ID" -> (known after apply)
      ~ secret_name     = "STAGING_ACCOUNT_ID" -> "STAGING_AWS_ACCOUNT_ID" # forces replacement
      ~ updated_at      = "2024-11-20 19:42:07 +0000 UTC" -> (known after apply)
        # (3 unchanged attributes hidden)
    }

  # github_actions_secret.api_account_id must be replaced
-/+ resource "github_actions_secret" "api_account_id" {
      ~ created_at      = "2024-11-27 18:32:09 +0000 UTC" -> (known after apply)
      ~ id              = "notification-api:STAGING_ACCOUNT_ID" -> (known after apply)
      ~ secret_name     = "STAGING_ACCOUNT_ID" -> "STAGING_AWS_ACCOUNT_ID" # forces replacement
      ~ updated_at      = "2024-11-27 18:32:09 +0000 UTC" -> (known after apply)
        # (3 unchanged attributes hidden)
    }

  # github_actions_secret.manifests_account_id must be replaced
-/+ resource "github_actions_secret" "manifests_account_id" {
      ~ created_at      = "2024-11-21 15:50:06 +0000 UTC" -> (known after apply)
      ~ id              = "notification-manifests:STAGING_ACCOUNT_ID" -> (known after apply)
      ~ secret_name     = "STAGING_ACCOUNT_ID" -> "STAGING_AWS_ACCOUNT_ID" # forces replacement
      ~ updated_at      = "2024-11-21 15:50:06 +0000 UTC" -> (known after apply)
        # (3 unchanged attributes hidden)
    }

Plan: 3 to add, 0 to change, 3 to destroy.

─────────────────────────────────────────────────────────────────────────────

Saved the plan to: plan.tfplan

To perform exactly these actions, run the following command to apply:
    terraform apply "plan.tfplan"
Show Conftest results
20 tests, 20 passed, 0 warnings, 0 failures, 0 exceptions

@ben851 ben851 merged commit 6b99553 into main Nov 27, 2024
29 checks passed
@ben851 ben851 deleted the aws-account-id branch November 27, 2024 19:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants