Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update missing translations #1692

Open
2 tasks
andrewleith opened this issue Nov 15, 2024 · 2 comments
Open
2 tasks

Update missing translations #1692

andrewleith opened this issue Nov 15, 2024 · 2 comments
Assignees
@andrewleith @amazingphilippe
Labels
Content l Contenu Tasks to write, edit or delete content from any Notify pages Dev Task for implementation of a technical solution

Comments

@andrewleith
Copy link
Member

Describe the bug

The process to check for missing translations isn't looking in .html files. Because of this we have missed several translations.

Here is a spreadsheet containing all the instances:
https://docs.google.com/spreadsheets/d/1osCm70Hm6PYRoABkR7zOF7p2tMH-tDhksdPw0Yns2Pk/edit?usp=sharing

Bug Severity

SEV-3 Minor

Impact

App is not bilingual in some places

If applicable, add screenshots to help explain your problem.

Acceptance criteria

  • Each missing translation has been added to the fr.csv file
  • babel.cfg has been updated to look for translations in .html files
@andrewleith andrewleith added Content l Contenu Tasks to write, edit or delete content from any Notify pages Dev Task for implementation of a technical solution labels Nov 15, 2024
@yaelberger-commits
Copy link
Collaborator

yaelberger-commits commented Nov 18, 2024 •
edited
Loading

Ran script, Phil QA'ing, some local tests, looking for bugs and glitches that may have been introduced

@amazingphilippe
Copy link
Collaborator

PR merged to staging. REady for next release

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@andrewleith andrewleith

@amazingphilippe amazingphilippe

Labels
Content l Contenu Tasks to write, edit or delete content from any Notify pages Dev Task for implementation of a technical solution
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@andrewleith @amazingphilippe @yaelberger-commits