Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom logos are displayed larger than expected #1679

Open
andrewleith opened this issue Oct 7, 2024 · 2 comments
Open

Custom logos are displayed larger than expected #1679

andrewleith opened this issue Oct 7, 2024 · 2 comments
Labels
Dev Task for implementation of a technical solution UX Design and prototyping

Comments

@andrewleith
Copy link
Member

andrewleith commented Oct 7, 2024

Describe the bug

Notify gives specific instructions for users to size their logos when they upload them, but when they follow them, the logo ends up larger than expected.

Note: If we fix this, we need to think about how to handle existing logos. We could either go back and fix them all, or perhaps only re-size images properly going forward.

If we can’t change how logos are displayed, we could instead change our instructions.

Instructions:

Your logo must be compatible with GC Notify. Check logo is:

In PNG image format
Exactly 108 pixels tall
Maximum 600 pixels wide

Result:
image

However, it should look like this:
image
SEV-4 Low

To Reproduce

Steps to reproduce the behavior:

  1. Upload a custom logo and follow the sizing instructions
  2. Logo is larger than expected

Expected behavior

  • Logo should be the same size as image uploaded

Impact

Impact on Notify users:

  • This could confuse users, reduce their trust in the product

Impact on Recipients:

  • If not corrected, the emails can look unprofessional, which could reduce/erode trust

Impact on Notify team:

  • Causes extra work to handle support cases, fix logos, etc.
@andrewleith andrewleith added UX Design and prototyping Dev Task for implementation of a technical solution labels Oct 7, 2024
@whabanks
Copy link

whabanks commented Nov 5, 2024

We had another instance of this bug causing issues with banner resizing: https://gcdigital.slack.com/archives/C03FA4DJCCU/p1730803609010149

@yaelberger-commits
Copy link
Collaborator

Temp fix is to use #FFFFFF background and select "Custom logo on a background colour"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Dev Task for implementation of a technical solution UX Design and prototyping
Projects
None yet
Development

No branches or pull requests

3 participants