Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dev: Suspend callbacks backend #1648

Closed
7 tasks done
whabanks opened this issue Aug 20, 2024 · 7 comments
Closed
7 tasks done

Dev: Suspend callbacks backend #1648

whabanks opened this issue Aug 20, 2024 · 7 comments
Assignees
Labels
Dev Task for implementation of a technical solution

Comments

@whabanks
Copy link

whabanks commented Aug 20, 2024

Description

As a Notify Team Member, I need to be made aware of callback failures via alarms so that I can take appropriate action to warn a service owner or suspend their callback functionality.

As a Notify Dev doing front end working, I need back end plumbing in place so that I can retrieve and update the suspension status of a service's callbacks.

Acceptance Criteria

  • Warning and Critical alarms are created/updated in Terraform. (Update and add callback alarms notification-terraform#1507)
    • Agree on less sensitive alarm thresholds from the ADR
  • Add admin code to suspend a callback through the setting page
  • Add API code to take is_suspended into account and not send the Callback
  • Add suspended and suspended_at columns to the service_callback_api table
  • Update ServiceCallbackApi model & associated schemas in API
  • Add new API endpoint to set suspended and suspended_at when suspending or resuming a callback.
@whabanks whabanks added the Dev Task for implementation of a technical solution label Aug 20, 2024
@yaelberger-commits
Copy link
Collaborator

Hey team! Please add your planning poker estimate with Zenhub @andrewleith @jzbahrai @whabanks

@yaelberger-commits
Copy link
Collaborator

Will & Jumana are each working on their own parts of this work today

@yaelberger-commits
Copy link
Collaborator

@jzbahrai has an Admin PR open, and an API PR open, both need reviews from Will

@yaelberger-commits
Copy link
Collaborator

API code needs to be merged, and Will's PR. Should get merged today

@yaelberger-commits
Copy link
Collaborator

PR up for API code suspended check.
One more task for front-end to add a testing URL for the users, last AC

@yaelberger-commits
Copy link
Collaborator

API PR merged and released in Prod

@yaelberger-commits
Copy link
Collaborator

We now have the ability to suspend/resume a callback service for any client (manually)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Dev Task for implementation of a technical solution
Projects
None yet
Development

No branches or pull requests

3 participants