Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs!: use mdbook, add css filters documentation #1445

Open
wants to merge 16 commits into
base: main
Choose a base branch
from

Conversation

uncenter
Copy link
Member

Closes #1089. Thanks @Papweer for the generated palette! Much appreciated.

@uncenter
Copy link
Member Author

I think we still need a better way of surfacing the tips somehow, not sure what the best way is. When new contributors are writing a userstyle their first instinct is most likely not to check tips and tricks lol.

Copy link
Contributor

@sgoudham sgoudham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thoughts on having a single docs/tips-and-tricks.md instead of a tips folder with multiple entries?

@uncenter
Copy link
Member Author

I mean that's what we have now, but I don't like it. Some of these examples/tips/triks are getting super long, and the doument as a whole is getting long as we add more tips. I would love an Mdbook of these and the rest of the docs actually if possible, but that might be something for later.

@sgoudham
Copy link
Contributor

Alright. I'd rename the tips folder to tips-and-tricks.

@uncenter uncenter changed the title docs!: restructure, add css filters documentation docs!: use mdbook, add css filters documentation Nov 13, 2024
Copy link
Member

@isabelroses isabelroses left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Re:

Userstyles labeled with the "🚧" emoji are looking for maintainers, and may
not work as intended. Contributions are still welcome and encouraged. If you
would like to become a maintainer, follow the instructions outlined in
"Adding yourself as a maintainer."

Instead of updating the link to be the new github link should we not point to the mdbook?

@uncenter uncenter marked this pull request as ready for review November 29, 2024 17:28
@uncenter uncenter requested a review from a team as a code owner November 29, 2024 17:28
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I feel like it would be "nicer" to symlink the README here, what do you think?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree sort of; how will we deal with conflicting links? If I link relatively from the symlinked README in the docs directory, it will work on the website, but not on the GitHub readme. And if I link to the website URL from the README, the links aren't really truly accurate on the mdbook page - for example if you were to develop on it and click those links, it would bring you to the deployed version and not the local version because it would be a full URL.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also the "edit this page" link would link to the symlink file on GitHub for the main page, which just contains the text "../../README.md"...

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah the only way that it would work is if you replaced the relative GitHub links on the main README with website URLs and avoided clicking those URLs during development. Don't think you can do anything about the "edit this page" link unless you modified the index.hbs ig.

Only reason I mentioned symlinking is that I fear that userstyles.catppuccin.com will become the main "entry" point for people to link to and it feels odd to not have all the main README information on the main page of the mdbook.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also while we're talking about links, it's probably a good idea to run https://github.com/Michael-F-Bryan/mdbook-linkcheck since we're linking to quite a few different places right?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure. Right now it will fail a ton since all of the userstyles.catppuccin.com links aren't up yet, maybe we add it later.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also the "edit this page" link would link to the symlink file on GitHub for the main page, which just contains the text "../../README.md"...

Can you technically flip the symlink so that the primary page is actually from the mdbook and not from the GitHub README? It feels like this book is going to take the spotlight from the GitHub README lol.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Document the CSS color filter generator technique for theming single color images
3 participants