Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Define the metric types #10

Open
1 of 4 tasks
brendanheywood opened this issue Feb 25, 2022 · 0 comments
Open
1 of 4 tasks

Define the metric types #10

brendanheywood opened this issue Feb 25, 2022 · 0 comments
Labels
enhancement New feature or request

Comments

@brendanheywood
Copy link
Collaborator

brendanheywood commented Feb 25, 2022

Ie different places allow different types of metrics eg:

  • Counter
  • Gauge
  • Histogram
  • Summary

https://prometheus.io/docs/concepts/metric_types/

It is very likely that for MVP we will only need 'Gauge' but I want to make sure we allow for future growth of other metric types. This probably boils down to the methods in the base metric object that each metric can declare.

Each collector will probably need to declare which metric types is can handle too

Probably also need to think about the units for each metric,eg Most will probably be 'Count'. We don't need to support all of them and this might be an internal implementation detail of each collector.

https://docs.aws.amazon.com/AmazonCloudWatch/latest/APIReference/API_MetricDatum.html

@brendanheywood brendanheywood added the enhancement New feature or request label May 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant