Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fatal error on T12 with missing grade items #61

Open
peterspicer-catalyst opened this issue Jan 30, 2020 · 0 comments
Open

Fatal error on T12 with missing grade items #61

peterspicer-catalyst opened this issue Jan 30, 2020 · 0 comments
Labels

Comments

@peterspicer-catalyst
Copy link

So we have a client on T12 with this plugin, and completions tag as COMPLETION_COMPLETE_PASS or COMPLETION_COMPLETE_FAIL as completion statuses for that client (as expected).

Problem is, on the course view for the activity, Totara 12 inside course/renderer.php tries to determine the icon to use for completion, and if the state is COMPLETION_COMPLETE_PASS or COMPLETION_COMPLETE_FAIL, it attempts to load the grade_item attached to the completion and this returns false (rather than a grade_item, because there isn't one) and fails because it can't determine if the grade_item is hidden or not.

This seems to be a non-trivial change to mod_reengagement but I think it might need to be fixed here rather than not. I've patched our client's Totara core for now so that if it doesn't get a grade_item, it just gives it the completed icon anyway.

@danmarsden danmarsden added the bug label Oct 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants