Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

imgpkg miscalculates apache/nifi copy, produces corrupt image layer when copying apache/nifi in a bundle #620

Open
TheBritz opened this issue Dec 21, 2023 · 1 comment
Labels
bug This issue describes a defect or unexpected behavior carvel accepted This issue should be considered for future work and that the triage process has been completed

Comments

@TheBritz
Copy link

Miscalculation during copy

What steps did you take:

  1. Ran imgpkg copy -i on apache/nifi
imgpkg copy -i apache/nifi:latest --to-repo my.registry.com/docker/apache/nifi

What happened:

  • imgpkg calculates an incorrect copy size (much too small)
  • copy progress continues past 100% to >1000% for a total of ~2GB
  • despite size and progress calculations, copy succeeds
    • copied image can be pulled via docker cli

What did you expect:

  • imgpkg correctly calculates image size and represents image copy progress

Corrupt image layer when copying in a bundle

What steps did you take:

  1. Create an image bundle that includes apache/nifi
  2. Publish image bundle
  3. Copy image bundle to a different registry
imgpkg copy -b my.registry.com/docker/apache/nifi-bundle:latest --to-repo my.registry2.com/docker/apache/nifi-bundle

What happened:

  • imgpkg calculates an incorrect copy size (much like when copying the direct image)
  • copy progress does not continue past 100%
  • copy indicates success
  • Image cannot be successfully pulled via docker cli
    • Attempting to pull will resort in a filesystem layer verification failed for digest <sha256> error

Environment:

  • imgpkg version (use imgpkg --version): 0.39.0
  • Docker registry used (e.g. Docker HUB): docker hub, nexus, artifactory (all exhibit same behavior)
  • OS (e.g. from /etc/os-release): RHEL 7.9

Vote on this request

This is an invitation to the community to vote on issues, to help us prioritize our backlog. Use the "smiley face" up to the right of this comment to vote.

👍 "I would like to see this addressed as soon as possible"
👎 "There are other more important things to focus on right now"

We are also happy to receive and review Pull Requests if you want to help working on this issue.

@TheBritz TheBritz added bug This issue describes a defect or unexpected behavior carvel triage This issue has not yet been reviewed for validity labels Dec 21, 2023
@praveenrewar
Copy link
Member

My understanding is that it's an issue with the underlying libraries that imgpkg uses (@joaopapereira should be able to confirm once he is back)

@renuy renuy moved this to To Triage in Carvel Jan 2, 2024
@renuy renuy added carvel accepted This issue should be considered for future work and that the triage process has been completed and removed carvel triage This issue has not yet been reviewed for validity labels Jan 2, 2024
@renuy renuy moved this from To Triage to Prioritized Backlog in Carvel Jan 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug This issue describes a defect or unexpected behavior carvel accepted This issue should be considered for future work and that the triage process has been completed
Projects
Status: Prioritized Backlog
Development

No branches or pull requests

3 participants