Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Review Episode 2 #93

Open
isazi opened this issue Nov 1, 2022 · 2 comments
Open

Review Episode 2 #93

isazi opened this issue Nov 1, 2022 · 2 comments
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed

Comments

@isazi
Copy link
Collaborator

isazi commented Nov 1, 2022

A large example has been added to episode 2, so if anyone is willing to read and review it, that would be appreciated.

@isazi isazi added enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed labels Nov 1, 2022
@bkmgit
Copy link

bkmgit commented Nov 2, 2022

Some general comments:

  • In the lesson prerequisites, access to an Nvidia GPU seems required or access to Google Colab. Maybe there are also restrictions on Cuda version supported or compute capability?
  • The image processing example and relation to astronomy is nice. As Python seems to be the main prerequisite, it may be helpful to assume background provided by the Carpentries Python lessons. As such, a little more explanation on computer architecture and algorithms may be helpful - in particular describing algorithmic patterns that will work well on a GPU
  • May also want to explain energy efficiency of GPUs not just speedup

@isazi
Copy link
Collaborator Author

isazi commented Nov 7, 2022

Thanks for the feedback @bkmgit we will take care of the comments as soon as possible.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants