Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Services are now sorted in a case-insensitive manner #152

Merged
merged 1 commit into from
Nov 18, 2023

Conversation

caronc
Copy link
Owner

@caronc caronc commented Nov 18, 2023

Description:

Related issue (if applicable): n/a

The primary reason for this was services like ntfy were showing up at the bottom of the list and not inline with the other services starting with N.

The list is now sorted in a case insensitive manner for an improved presentation.

Checklist

  • The code change is tested and works locally.
  • There is no commented out code in this PR.
  • No lint errors (use flake8)
  • Tests added

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (9ee3fd6) 95.23% compared to head (53977a7) 95.23%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #152   +/-   ##
=======================================
  Coverage   95.23%   95.23%           
=======================================
  Files           7        7           
  Lines         714      714           
=======================================
  Hits          680      680           
  Misses         34       34           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@caronc caronc merged commit f97134b into master Nov 18, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants