Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Password files with spaces in them are broken #195

Open
cincodenada opened this issue Jul 2, 2020 · 0 comments
Open

Password files with spaces in them are broken #195

cincodenada opened this issue Jul 2, 2020 · 0 comments

Comments

@cincodenada
Copy link
Contributor

cincodenada commented Jul 2, 2020

I just pulled down the latest changes and found that rofi-pass was very broken with the latest version:

rofipassbug

As you might guess, I don't have a bunch of passwords named "-" and one named "@" (nor do I have one named simply "Adventure"). What I do have is a bunch of password files with spaces in their names: several in the format "Thing - subthing", one in the format "user @ service", and another for "Next Adventure".

Upon investigation, it seems that the fix for #191 caused the password file list to be split on spaces instead of newlines, thus rendering any password files with spaces in them inoperable. I've submitted PR #194 to resolve the issue and once again handle passwords with spaces in them as expected, while still using the new find command.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant