Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug]: Update notification-background-warning token #17586

Closed
1 task done
Kritvi-bhatia17 opened this issue Sep 26, 2024 · 0 comments · Fixed by #17621
Closed
1 task done

[Bug]: Update notification-background-warning token #17586

Kritvi-bhatia17 opened this issue Sep 26, 2024 · 0 comments · Fixed by #17621
Assignees
@ariellalgilmore
Labels
component: notification package: themes @carbon/themes severity: 2 https://ibm.biz/carbon-severity type: bug 🐛

Comments

@Kritvi-bhatia17
Copy link
Contributor

Kritvi-bhatia17 commented Sep 26, 2024 •
edited
Loading

Description

  • Update $notification-background-warning to yellow 10 for white and gray 10 themes.

Currently there is a mix happening between Yellow 30 and White 0, which matches what is currently showing on the Color page of the website. This has been the case since v10, as originally IDL didn’t have a full yellow palette. The Yellow 10 value was added later, which explains why the current color map reflects this.

For more context
@alisonjoseph alisonjoseph changed the title [Bug]: Update token for hex value #fcf4d6 to Yellow 10 [Bug]: Update notification-background-warning token Sep 26, 2024
@alisonjoseph alisonjoseph moved this to ⏱ Backlog in Design System Sep 26, 2024
@ariellalgilmore ariellalgilmore self-assigned this Sep 26, 2024
@Kritvi-bhatia17 Kritvi-bhatia17 mentioned this issue Sep 26, 2024
Merged
@ariellalgilmore ariellalgilmore mentioned this issue Oct 1, 2024
Merged
@github-project-automation github-project-automation bot moved this from 🚦 In Review to ✅ Done in Design System Oct 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ariellalgilmore ariellalgilmore

Labels
component: notification package: themes @carbon/themes severity: 2 https://ibm.biz/carbon-severity type: bug 🐛
Projects
Design System
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(notification): background-warning-token to use yellow10 ariellalgilmore/carbon
3 participants
@alisonjoseph @ariellalgilmore @Kritvi-bhatia17