-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(17398): fix Datepicker issue with Keyboard Navigation in Firefox #17435
fix(17398): fix Datepicker issue with Keyboard Navigation in Firefox #17435
Conversation
✅ Deploy Preview for carbon-elements ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for v11-carbon-react ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #17435 +/- ##
==========================================
- Coverage 76.82% 76.82% -0.01%
==========================================
Files 408 408
Lines 13973 13974 +1
Branches 4341 4289 -52
==========================================
Hits 10735 10735
- Misses 3064 3066 +2
+ Partials 174 173 -1 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good to me on all browsers!
47ceaad
Hey @2nikhiltom looks like the focus still blocked in the last element on Firefox I'm not sure if the issue closed is different or the same as this one: #17663 |
Closes #17398
This fixes the keyboard (Tab) navigation order in FireFox
Changelog
added event.preventDefault();
Testing / Reviewing
open deploy preview in FireFox
Open DatePicker - "range with Calendar" storybook example
Select the dates using keyboard after selection of end date press tab and verify that the focus moves to the next focusable element in the DOM
Also verify in other browser