Update ref handling and adjust label component indentation #17097
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Updated the ref handling condition from Object(ref) === ref to 'current' in ref for improved clarity and accuracy. - Adjusted the indentation of the label component for consistency and readability.
|
All contributors have signed the DCO. |
✅ Deploy Preview for v11-carbon-react ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for carbon-elements ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
I have read the DCO document and I hereby sign the DCO. |
|
recheck |
preetibansalui
approved these changes
Aug 5, 2024
emyarod
reviewed
Aug 5, 2024
tay1orjones
approved these changes
Oct 15, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #17097 +/- ##
=======================================
Coverage 80.14% 80.14%
=======================================
Files 406 406
Lines 14030 14030
Branches 4343 4343
=======================================
Hits 11245 11245
Misses 2619 2619
Partials 166 166 ☔ View full report in Codecov by Sentry. |
✅ Deploy Preview for v11-carbon-web-components ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Merged
via the queue into
carbon-design-system:main
with commit Oct 23, 2024
265dc17
39 of 40 checks passed
|
Hey there! v11.69.0 was just released that references this issue/PR. |
irfadkp
pushed a commit
to irfadkp/carbon
that referenced
this pull request
Oct 24, 2024
…sign-system#17097) * Refactor ref handling and label indentation - Updated the ref handling condition from Object(ref) === ref to 'current' in ref for improved clarity and accuracy. - Adjusted the indentation of the label component for consistency and readability. * chore: run yarn format --------- Co-authored-by: Taylor Jones <[email protected]> Co-authored-by: Taylor Jones <[email protected]> Co-authored-by: Alison Joseph <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Object(ref) === refto'current' in reffor improved clarity and accuracy. This change simplifies the check for object refs and aligns with common React practices.Closes #<issue_number>
Changelog
New
Changed
Object(ref) === refto'current' in reffor improved clarity and alignment with React practices.<label>component adjusted for consistency and readability.Removed
Testing / Reviewing
To verify these changes:
Checkboxcomponent to ensure it properly distinguishes between function and object refs.<label>start tag are correctly applied, ensuring there are no syntax errors or unexpected issues, and confirm that the tag displays properly.