Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reconfigure UI Shell stories to show fully accessible examples #13419

Closed
2 tasks
Tracked by #12323
tay1orjones opened this issue Mar 28, 2023 · 0 comments · Fixed by #14127
Closed
2 tasks
Tracked by #12323

Reconfigure UI Shell stories to show fully accessible examples #13419

tay1orjones opened this issue Mar 28, 2023 · 0 comments · Fixed by #14127
Assignees
Milestone

Comments

@tay1orjones
Copy link
Member

tay1orjones commented Mar 28, 2023

Surfaced in #12323:

Side rail implementation on Storybook failing to handle content in breakpoint - and has an 'impossible' version.

The non-persistent left nav that arises from responsive design is quite similar to the Side rail variation, which reveals a consistently non-persistent left nav. It's quite a nice implementation, and Carbon may want to consider how the variations can be merged into something consistent and best.

However, the implementation of the side rail with header has a significant glitch and some cautions.

The first is, what is the point of having a side rail and a hamburger menu? They both do the same thing (and have the same content!). If the side fail is implemented, there does not seem to be any reason to have a hamburger menu.

Secondly, in the storybook implementation, the 4 links displayed at the top of the nav, which disappear due to response design at about 175% zoom, do NOT appear in the left 'rail' or in the hamburger menu. They should.

Thirdly, there is an implementation of side rail without a UI Shell header. I believe it is impossible to have no UI Shell header -- that it is a requirement of all Carbon pages. Is there some other use case where this makes sense?
That aside, if you consider how the side rail works without the need for the hamburger menu here, you can see that it serves as further evidence that there is NO NEED for the hamburger menu when side rail is used. As mentioned above, where responsive design collapses the top nav, those links can just appear at the top of the side rail content

There isn't an inherent defect here, other than the stories showing components in isolation that therefore have accessibility issues. The suggested outcome of this issue is to focus towards reconfiguring the stories to match the following:

Tasks

@tay1orjones tay1orjones moved this to ⏱ Backlog in Design System Mar 28, 2023
@tay1orjones tay1orjones changed the title Reconfigure uishell stories to show fully in-flight and fully accessible examples, isolated stories should be removed or put behind a dev-only flag Reconfigure UI Shell stories to show fully accessible examples Mar 28, 2023
@sstrubberg sstrubberg added this to the 2023 Q2 milestone Mar 29, 2023
@guidari guidari moved this from ⏱ Backlog to 🏗 In Progress in Design System Jun 19, 2023
@guidari guidari mentioned this issue Jun 26, 2023
7 tasks
@guidari guidari moved this from 🏗 In Progress to 🚦 In Review in Design System Jun 29, 2023
@guidari guidari mentioned this issue Jun 30, 2023
7 tasks
@github-project-automation github-project-automation bot moved this from 🚦 In Review to ✅ Done in Design System Jul 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

3 participants