Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support growing the VM disk size without needing to reboot the VM #13311

Open
tomponline opened this issue Apr 11, 2024 · 6 comments · May be fixed by #14211
Open

Support growing the VM disk size without needing to reboot the VM #13311

tomponline opened this issue Apr 11, 2024 · 6 comments · May be fixed by #14211
Assignees
@kadinsayani
Labels
Feature New feature, not a bug Maybe Undecided whether in scope for the project
Milestone
soon

Comments

@tomponline
Copy link
Member

This has been requested as something users would expect.
@tomponline tomponline added Feature New feature, not a bug Maybe Undecided whether in scope for the project labels Apr 11, 2024
@tomponline
Copy link
Member Author

lxc/incus#1158

@tomponline tomponline added this to the soon milestone Sep 27, 2024
@kadinsayani
Copy link
Contributor

I think we'll also need a few commits from lxc/incus#1166.

@tomponline
Copy link
Member Author

Good spot

@tomponline
Copy link
Member Author

Can you review that PR in full and see which commits are suitable (even if not directly related to resizing) ta.

@kadinsayani
Copy link
Contributor

Can you review that PR in full and see which commits are suitable (even if not directly related to resizing) ta.

Sure thing!

@kadinsayani kadinsayani linked a pull request Oct 7, 2024 that will close this issue
Open
@kadinsayani
Copy link
Contributor

@tomponline I've included the commits relevant to resizing VM disks in #14211. The other two commits in lxc/incus#1166 relate to hashing block node names if they exceed the maximum length. Currently in LXD, AFAIK, we don't perform any hashing for block node names, so commits lxc/incus@371745b and lxc/incus@d08911f from Incus may be useful for us.

@kadinsayani kadinsayani mentioned this issue Nov 13, 2024
Merged
tomponline added a commit that referenced this issue Nov 19, 2024
@tomponline
VM: Add missing disk block node name overflow handling (#14461)
a1c7a56 
Two commits were identified as potential imports in
#13311:
The first commit adds a function `blockNodeName` which hashes block node
names if they exceed 31 characters. The second commit applies the node
name overflow function when adding a QEMU config to a drive.

@simondeziel pointed out that we already have a function
`qemuDeviceNameOrID` so this PR just adds missing node name overflow
handling.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kadinsayani kadinsayani

Labels
Feature New feature, not a bug Maybe Undecided whether in scope for the project
Projects
None yet
Milestone
soon
2 participants
@tomponline @kadinsayani