Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove the deprecated CloseNotify function #288

Open
iawia002 opened this issue Aug 23, 2019 · 1 comment
Open

remove the deprecated CloseNotify function #288

iawia002 opened this issue Aug 23, 2019 · 1 comment

Comments

@iawia002
Copy link

Is this a BUG REPORT or FEATURE REQUEST?:

Uncomment only one, leave it on its own line:

/kind bug
/kind feature

What happened:

nirvana/service/context.go

Lines 208 to 211 in 854a462

// CloseNotify is a disguise of http.response.CloseNotify().
func (c *response) CloseNotify() <-chan bool {
return c.writer.(http.CloseNotifier).CloseNotify()
}

the original CloseNotifier interface was marked as Deprecated since Go 1.11, the user should use http.Request.Context.Done() as instead. Should we remove this too?

PS: this will trigger a lint problem (#287)

What you expected to happen:

How to reproduce it (as minimally and precisely as possible):

Anything else we need to know?:

/cc @kdada

@kdada
Copy link
Collaborator

kdada commented Aug 26, 2019

Just do it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants