You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
// CloseNotify is a disguise of http.response.CloseNotify().
func (c*response) CloseNotify() <-chanbool {
returnc.writer.(http.CloseNotifier).CloseNotify()
}
the original CloseNotifier interface was marked as Deprecated since Go 1.11, the user should use http.Request.Context.Done() as instead. Should we remove this too?
Is this a BUG REPORT or FEATURE REQUEST?:
What happened:
nirvana/service/context.go
Lines 208 to 211 in 854a462
the original
CloseNotifier
interface was marked asDeprecated
since Go 1.11, the user should usehttp.Request.Context.Done()
as instead. Should we remove this too?PS: this will trigger a lint problem (#287)
What you expected to happen:
How to reproduce it (as minimally and precisely as possible):
Anything else we need to know?:
/cc @kdada
The text was updated successfully, but these errors were encountered: