Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug Fix: Hide and Seek #16

Open
kwekubright opened this issue May 13, 2022 · 0 comments
Open

Bug Fix: Hide and Seek #16

kwekubright opened this issue May 13, 2022 · 0 comments

Comments

@kwekubright
Copy link
Collaborator

Issue:

  • Modal popup won't close after displaying

Suggestion:
On line 56 in popup-window.js, when cloning the template using firstChild will prevent the document fragment pitfall where elements cannot listen to events.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@kwekubright