Allow specifying/retaining names of downloaded files. #488
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
butlerx
reviewed
Aug 23, 2023
| fileName = window.atob(fileNameBase64); | ||
| } | ||
| } catch (err) { | ||
| // Filename wasn't base64-encoded so let's ignore it |
There was a problem hiding this comment.
Is there a reason to base64 encode the filename?
There was a problem hiding this comment.
If it is not encoded/escaped and contains a :, using : as a separator would not work correctly. Base64-encoding seemed like the easiest option that is guaranteed to work, but there are certainly other options that would work too!
butlerx
reviewed
Aug 23, 2023
src/client/wetty/download.ts
Outdated
| // Filename wasn't base64-encoded so let's ignore it | ||
| } | ||
|
|
||
| if (typeof fileName !== "string") { |
There was a problem hiding this comment.
Im not a big fan of typeof checks as it implies the type can change.
Given the type is string|undefined could the check be is fileName === undefined
butlerx
reviewed
Aug 23, 2023
butlerx
approved these changes
Sep 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows the name of downloaded files to be specified by prepending
base64(filename):to the file contents after a^[[5i.It seems the implementation allows the file contents to not be base64 encoded, and in that case downloading a file containing a
:would break with these changes. In other cases, such as when using the documented bash function, this should be backwards compatible.