-
-
Notifications
You must be signed in to change notification settings - Fork 262
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
reflection detection doesn't work for structs containing functions which return structs #817
Labels
Comments
lu4p
added a commit
that referenced
this issue
Nov 26, 2024
lu4p
added a commit
that referenced
this issue
Nov 26, 2024
lu4p
added a commit
that referenced
this issue
Nov 27, 2024
lu4p
added a commit
that referenced
this issue
Nov 27, 2024
lu4p
added a commit
that referenced
this issue
Nov 27, 2024
lu4p
added a commit
that referenced
this issue
Nov 27, 2024
lu4p
added a commit
that referenced
this issue
Nov 27, 2024
lu4p
added a commit
that referenced
this issue
Nov 27, 2024
lu4p
added a commit
that referenced
this issue
Nov 27, 2024
Go code can retrieve and use field and method names via the `reflect` package. For that reason, historically we did not obfuscate names of fields and methods underneath types that we detected as used for reflection, via e.g. `reflect.TypeOf`. However, that caused a number of issues. Since we obfuscate and build one package at a time, we could only detect when types were used for reflection in their own package or in upstream packages. Use of reflection in downstream packages would be detected too late, causing one package to obfuscate the names and the other not to, leading to a build failure. A different approach is implemented here. All names are obfuscated now, but we collect those types used for reflection, and at the end of a build in `package main`, we inject a function into the runtime's `internal/abi` package to reverse the obfuscation for those names which can be used for reflection. This does mean that the obfuscation for these names is very weak, as the binary contains a one-to-one mapping to their original names, but they cannot be obfuscated without breaking too many Go packages out in the wild. There is also some amount of overhead in `internal/abi` due to this, but we aim to make the overhead insignificant. Fixes #884, #799, #817, #881, #858, #843, #842 Closes #406
lu4p
added a commit
that referenced
this issue
Nov 27, 2024
Go code can retrieve and use field and method names via the `reflect` package. For that reason, historically we did not obfuscate names of fields and methods underneath types that we detected as used for reflection, via e.g. `reflect.TypeOf`. However, that caused a number of issues. Since we obfuscate and build one package at a time, we could only detect when types were used for reflection in their own package or in upstream packages. Use of reflection in downstream packages would be detected too late, causing one package to obfuscate the names and the other not to, leading to a build failure. A different approach is implemented here. All names are obfuscated now, but we collect those types used for reflection, and at the end of a build in `package main`, we inject a function into the runtime's `internal/abi` package to reverse the obfuscation for those names which can be used for reflection. This does mean that the obfuscation for these names is very weak, as the binary contains a one-to-one mapping to their original names, but they cannot be obfuscated without breaking too many Go packages out in the wild. There is also some amount of overhead in `internal/abi` due to this, but we aim to make the overhead insignificant. Fixes #884, #799, #817, #881, #858, #843, #842 Closes #406
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
While debugging #690 I found another case where reflection detection breaks down.
This is mostly a constructed esoteric case, however I want to save it for future reference.
This:
becomes:
In an ideal world the return type shouldn't be obfuscated anywhere.
The text was updated successfully, but these errors were encountered: