Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement canonize_site! for MPO #249

Open
jofrevalles opened this issue Nov 13, 2024 · 1 comment
Open

Implement canonize_site! for MPO #249

jofrevalles opened this issue Nov 13, 2024 · 1 comment
Labels
bug Something isn't working good first issue Good for newcomers

Comments

@jofrevalles
Copy link
Member

Since PR #232, we have defined canonize for AbstractMPO struct. I believe this should be AbstractMPS, since for now we don't have canonize_site! (the inner function called inside canonize). @mofeing

See:

julia> using Tenet

julia> mpo = rand(MPO, n=10, maxdim=10)
MPO (inputs=10, outputs=10)

julia> canonize!(mpo)
ERROR: MethodError: no method matching canonize_site!(::MPO, ::Site{1}; direction::Symbol, method::Symbol)
The function `canonize_site!` exists, but no method is defined for this combination of argument types.

Closest candidates are:
  canonize_site!(::MPS, ::Site; direction, method)
   @ Tenet ~/git/Tenet.jl/src/MPS.jl:501

Stacktrace:
 [1] canonize!::MPO)
   @ Tenet ~/git/Tenet.jl/src/MPS.jl:545
 [2] top-level scope
   @ REPL[4]:1
@mofeing
Copy link
Member

mofeing commented Nov 13, 2024

In principle, the only thing you need to do for canonize! to work with MPO is to implement canonize_site! for MPO.

@mofeing mofeing changed the title Change canonize argument to AbstractMPS instead of AbstractMPO Implement canonize_site! for MPO Nov 13, 2024
@mofeing mofeing added good first issue Good for newcomers bug Something isn't working labels Nov 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants