You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
But obviously at some point, the lib/ path was relevant. (My guess is that pyret-codemirror-mode was once installed in codemirror/addon, which i'm not sure why or how that would happen.) That means to me that this "path guessing" is not a good approach. That said, i don't think this would interfere with CPO because looking at the usage, it appears that it's following the // Plain browser env path, so for an easy fix this is an option.
Alternatively, we could keep working on PR #6, because a peer dependency does seem to be the more 'principled' way to do this (and react-codemirror2 specifically warns that non-peer dependencies on CodeMirror can cause really subtle bugs).
Finally, we could check if (CodeMirror) first, therefore allowing anyone to use the window.CodeMirror hack if the module directories aren't exactly as they should be.
Thoughts on the right approach?
The text was updated successfully, but these errors were encountered:
The following diff will make matchkw work with anchor/ide:
But obviously at some point, the lib/ path was relevant. (My guess is that pyret-codemirror-mode was once installed in codemirror/addon, which i'm not sure why or how that would happen.) That means to me that this "path guessing" is not a good approach. That said, i don't think this would interfere with CPO because looking at the usage, it appears that it's following the
// Plain browser env
path, so for an easy fix this is an option.Alternatively, we could keep working on PR #6, because a peer dependency does seem to be the more 'principled' way to do this (and react-codemirror2 specifically warns that non-peer dependencies on CodeMirror can cause really subtle bugs).
Finally, we could check
if (CodeMirror)
first, therefore allowing anyone to use the window.CodeMirror hack if the module directories aren't exactly as they should be.Thoughts on the right approach?
The text was updated successfully, but these errors were encountered: