Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

function collapse loses name in case it has a parameterized type #11

Open
shriram opened this issue Sep 15, 2023 · 0 comments
Open

function collapse loses name in case it has a parameterized type #11

shriram opened this issue Sep 15, 2023 · 0 comments

Comments

@shriram
Copy link
Member

shriram commented Sep 15, 2023

Here are two function definitions:

image

Let's collapse them:

image

The first one preserves its name, but the second loses it.

@blerner says:

Philip already hacked in support for retaining the function name as visible here (https://github.com/brownplt/pyret-codemirror-mode/blob/master/mode/pyret.js#L404), but it isn't aware of how to handle angle brackets (which are usually tokenized as punctuation).

Credit to Ross Williams at Brown for finding this bug.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant