Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

merge: Batches not getting Unreferenced #5171

Merged
merged 1 commit into from
Jul 9, 2024
Merged

merge: Batches not getting Unreferenced #5171

merged 1 commit into from
Jul 9, 2024

Conversation

mattnibs
Copy link
Collaborator

@mattnibs mattnibs commented Jul 5, 2024

This commit fixes an issue where the merge operator was not properly unreferencing batches.

@mattnibs mattnibs requested a review from a team July 5, 2024 18:45
This commit fixes an issue where the merge operator was not properly
unreferencing batches.
@philrz
Copy link
Contributor

philrz commented Jul 9, 2024

Since this PR held the promise of reducing the memory usage during compaction, I re-ran the tests that had previously flagged the problem and posted a write-up. The tl;dr is that it does indeed reduce memory during compaction by about 3.5x at the smaller object sizes, though memory consumption is still higher during the compaction phase than the load phase at these smaller object sizes.

Also just to test for general stability, I did a run through all the Autoperf tests using this branch at commit 6f67560. I can testify that it survived all the tests and I reviewed the summary dashboard and rather than assemble a bunch of screenshots that effectively show flat lines I can also say that it didn't cause any statistically significant deltas in the macro trends compared to other recent test runs at tip of main.

In conclusion, it's a functional 👍 for me.

@mattnibs mattnibs merged commit 6b4afe5 into main Jul 9, 2024
3 checks passed
@mattnibs mattnibs deleted the merge-unref branch July 9, 2024 16:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants