Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unnecessary HTML and CSS #32

Open
jaydson opened this issue Oct 10, 2018 · 2 comments
Open

Remove unnecessary HTML and CSS #32

jaydson opened this issue Oct 10, 2018 · 2 comments
Labels
bug Something isn't working good first issue Good for newcomers help wanted Extra attention is needed

Comments

@jaydson
Copy link
Member

jaydson commented Oct 10, 2018

This issue is related to #26 .
As we should keep our email around 102KB to avoid Gmail (and other clients) to clip the message, we should remove all trashy code we have.
In a quick I look I was able to find a lot of in-line CSS in our template.
This in-line CSS are being copied for each item, causing a big size in KB.
@jaydson jaydson added bug Something isn't working help wanted Extra attention is needed good first issue Good for newcomers labels Oct 10, 2018
@RenatoSiqueira
Copy link
Contributor

i will try!

@RenatoSiqueira
Copy link
Contributor

PR #32

felipenmoura added a commit that referenced this issue Apr 6, 2019
@felipenmoura
Merge pull request #33 from RenatoSiqueira/master
dab6d1b 
Issue #32
Let’s merge it, as it helps at least with firefox, and we can improve it even more later.
Thanks @RenatoSiqueira :)
@lucaspdroz lucaspdroz mentioned this issue Oct 18, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jaydson @RenatoSiqueira