Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enforce certain safety features even in unsafe_* by default #63

Open
jcoleman opened this issue Sep 24, 2021 · 0 comments
Open

Enforce certain safety features even in unsafe_* by default #63

jcoleman opened this issue Sep 24, 2021 · 0 comments

Comments

@jcoleman
Copy link
Contributor

From discussion in #22:

...it might well be the case that all of the unsafe variants (where it's relevant) should use the safe lock acquisition. I think that's mostly a project policy discussion, since it means the unsafe variants are increasingly not just proxies for the original Rails method (though we've already gone down that path somewhat with the dependent object checks).

ISTM that what we might want here is to move from 2 layers (safe_* and unsafe_*) to 3 layers: safe_*, unsafe_* to prevent clear database level issues (e.g., provide safe locking), and insert a new layer (maybe raw_*?) to be a pure dispatch into the original ActiveRecord implementation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant