Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add new engine_opSealPayload API #248

Open
wants to merge 8 commits into
base: develop
Choose a base branch
from

Conversation

bnoieh
Copy link
Contributor

@bnoieh bnoieh commented Oct 8, 2024

Description

This PR adds new engine_opSealPayload API, which can be enabled by flag --sequencer.combined-api.
If enabled, sequencer will call engine_opSealPayload instead of engine_getPayload/engine_newPayload/engine_forkchoiceUpdated to confirm unsafe payloads when producing block.

The related PR of support new engine_opSealPayload API in op-geth: bnb-chain/op-geth#193

Rationale

Through load test, we found that it took about 200ms(10k tps case) to call/serve of engine apis. So we add this new API to reduce the latency to almost 0ms here to achieve higher TPS.

Example

n/a

Changes

Notable changes:

  • use new flag --sequencer.combined-api to change to call new engine_opSealPayload API when producing unsafe block
# original flow
1. op-node call engine_forkchoiceUpdated
2. wait scheduled time
3. op-node call sequentially: engine_getPayload -> engine_newPayload -> engine_forkchoiceUpdated

# new flow when enable --sequencer.combined-api
1. op-node call engine_forkchoiceUpdated
2. wait scheduled time
3. op-node call concurrently: engine_opSealPayloadResponse & engine_getPayload
  • only unsafe block building will use engine_opSealPayload

@bnoieh bnoieh changed the base branch from main to develop October 8, 2024 10:33
@bnoieh bnoieh marked this pull request as ready for review October 18, 2024 11:08
@bnoieh bnoieh changed the title [PoC] perf: support combined engine api and optimize overheads feat: add new engine_opSealPayload API Oct 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant