feat: implement BEP-333(BNB Chain Fusion) #381

j75689 · 2024-01-15T06:28:45Z

Description

Implement the functions for the BC-Fusion plan.

The Beacon Chain in the BC-Fusion plan consists of four stages:

FirstSunsetFork - Disable Certain Message Types:
In this stage, the system will disable specific message types to prevent users from creating additional assets on the Beacon Chain. The following Msgs will be disabled:
- TimeLockMsg
- TimeRelockMsg
- FreezeMsg
- IssueMsg
- MintMsg
- IssueMiniMsg
- HTLTMsg
- DepositHTLTMsg
- MsgSideChainDelegate
- MsgSideChainRedelegate
- MsgCreateSideChainValidator
- MsgCreateSideChainValidatorWithVoteAddr
- MsgEditSideChainValidator
- MsgEditSideChainValidatorWithVoteAddr
MsgSideChainStakeMigration will be enabled to allow users to redelegate tokens to BSC.
MsgSideChainSubmitProposal will be disabled after the SideChain Total Voting Power falls below 5M BNB.
SecondSunsetFork - Token Refunding:
During this stage, the system will process token refunds for users who have assets locked on the Beacon Chain. Refunds will be initiated for TimeLock, AtomicSwap, and Delegation on the side chain. MsgSideChainUndelegate on the Beacon Chain will be disabled to prevent undelegation and ensure system efficiency.
FinalSunsetFork - Closure of Cross-Chain Channels:
This marks the final stage of BC-Fusion. The system will close all cross-chain channels. After the FinalSunsetFork, the system will no longer support cross-chain transactions.
Token Migration:
After the FinalSunsetFork, users may still have assets on the Beacon Chain. The system will support token migration, allowing users to move their assets to BSC. For detailed instructions, please refer to BEP-299.

Rationale

For the reasoning behind this plan, refer to BEP-333.

Example

n/a

Notable Changes

Tokens
Staking
Governance
IBC

) * fix: handleMsgSideChainUndelegate should not pass prefixCtx * fix: nil pointer when doing ibc method in endblock

…ion (#364)

…in endblock (#365)

* feat: add `MsgSideChainStakeMigration` and `StakeMigrationApp` * add missing tag * fix `handleMsgSideChainStakeMigration` * fix review comments * rename `MsgTypeSideChainStakeMigration` * add fee param for `MsgSideChainStakeMigration`

…ion` (#376)

…nPackage and prevent too many failed in auto refund (#377) * feat: add IsAutoUnDelegate field to CrossStakeDistributeUndelegatedSynPackage * fix: disable undelegate after SecondSunsetFork and prevent too many failed in auto refund * chore: add more logs * revert: cross stake changes * fix: error handling in refund * fix: transferPackage * fix: CrossStakeDistributeUndelegatedSynPackageV2

…unsetFork (#379) * fix: do not charge relayerFee for auto cross undelegate after SecondSunsetFork * fix: FeeCalculator

codecov-commenter · 2024-01-15T06:36:07Z

Codecov Report

Merging #381 (dc761f4) into develop (5a7b238) will decrease coverage by 0.71%.
The diff coverage is 6.22%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files

@@             Coverage Diff             @@
##           develop     #381      +/-   ##
===========================================
- Coverage    45.82%   45.12%   -0.71%     
===========================================
  Files          248      249       +1     
  Lines        24263    24671     +408     
===========================================
+ Hits         11119    11132      +13     
- Misses       12476    12867     +391     
- Partials       668      672       +4

forcodedancing · 2024-01-24T07:21:30Z

x/stake/handler.go

@@ -40,19 +43,42 @@ func NewHandler(k keeper.Keeper, govKeeper gov.Keeper) sdk.Handler {
 			return handleMsgUndelegate(ctx, msg, k)
 		// case MsgSideChain
 		case types.MsgCreateSideChainValidator:
+			if sdk.IsUpgrade(sdk.FirstSunsetFork) {
+				return sdk.ErrMsgNotSupported("").Result()
+			}
 			return handleMsgCreateSideChainValidator(ctx, msg, k)
 		case types.MsgEditSideChainValidator:


Why MsgEditSideChainValidator is not disabled like MsgEditSideChainValidatorWithVoteAddr?

`SideConsAddr` edition was allowed by BEP159, user can only change consAddr on testnet.

forcodedancing · 2024-01-24T12:31:45Z

x/stake/endblock.go

+		}, k)
+		refundEvents = refundEvents.AppendEvents(result.Events)
+		if !result.IsOK() {
+			ctx.Logger().Debug("handleRefundStake failed",


Is Debug level enough?

maybe Info level would be better

forcodedancing · 2024-01-24T12:38:58Z

x/stake/keeper/delegation.go

+			Amount:           bscTransferAmount,
+			Recipient:        recipient,
+			Validator:        valAddr,
+			IsAutoUnDelegate: k.IsAutoUnDelegate(ctx, delAddr, valAddr),


IsAutoUnDelegate is called twice in the func. Maybe we can have a local variable.

forcodedancing · 2024-01-24T12:43:54Z

x/stake/endblock.go

+			// this is to prevent too many delegation is in unbounded state
+			// if too many delegation is in unbounded state, it will cause too many iteration in the block
+			failedCount++
+			if failedCount >= maxProcessedRefundFailed {


At the edge case, when we reach maxProcessedRefundFailed, we cannot refund any records even in the following blocks.

that is expected, if too many user undelegate by themself, we should wait for them to be completed.
but don't worry, undelegate is disable after secondSunsetFork, so the max time we wait for is 7days.

…ne codes (#383)

* fix: fix nil validator when publishing message (#356) * feat: implement BEP-333(BNB Chain Fusion) (#381) * feat: bc fusion hardfork implementation (#358) * fix: panic issue when doing refundStake and closeCorssChainChannel (#362) * fix: handleMsgSideChainUndelegate should not pass prefixCtx * fix: nil pointer when doing ibc method in endblock * fix: add logs to sunset fork events and immediate sidechain undelegation (#364) * fix: revert immediate sidechain undelegation and handle undelegation in endblock (#365) * fix: disable ClaimMsg after FinalSunsetFork (#366) * feat: add `MsgSideChainStakeMigration` and `StakeMigrationApp` (#367) * feat: add `MsgSideChainStakeMigration` and `StakeMigrationApp` * add missing tag * fix `handleMsgSideChainStakeMigration` * fix review comments * rename `MsgTypeSideChainStakeMigration` * add fee param for `MsgSideChainStakeMigration` * fix: add missing register for new msg (#368) * fix: error within `CreateRawIBCPackageByIdWithFee` (#369) * fix: decimal for BCFusionStopGovThreshold (#370) * fix: panic when totally unbound the validator in voting period (#371) * fix: add missing event (#372) * fix: wrong json tag (#373) * fix: add missing tag of relayer fee in `handleMsgSideChainStakeMigration` (#376) * feat: add IsAutoUnDelegate field to CrossStakeDistributeUndelegatedSynPackage and prevent too many failed in auto refund (#377) * feat: add IsAutoUnDelegate field to CrossStakeDistributeUndelegatedSynPackage * fix: disable undelegate after SecondSunsetFork and prevent too many failed in auto refund * chore: add more logs * revert: cross stake changes * fix: error handling in refund * fix: transferPackage * fix: CrossStakeDistributeUndelegatedSynPackageV2 * fix: reset context every time in refund loop (#378) * fix: do not charge relayerFee for auto cross undelegate after SecondSunsetFork (#379) * fix: do not charge relayerFee for auto cross undelegate after SecondSunsetFork * fix: FeeCalculator * chore: add logs for processed refunding count (#380) * fix: close mirror, mirrorSync channel after FinalSunsetFork (#382) * fix: disable MsgEditSideChainValidator after FirstSunsetFork and refine codes (#383) * fix: change StakeMigrationRelayFee to 0.002BNB (#384) * fix: appHash mismatch causes by channelsMap (#385) --------- Co-authored-by: Roshan <[email protected]> * docs: add change logs for release 0.26.7 (#386) --------- Co-authored-by: forcodedancing <[email protected]> Co-authored-by: dylanhuang <[email protected]> Co-authored-by: Roshan <[email protected]>

TheManager73

Status
Migrated
Self Stake
0
Latest Delegators
698
Since Time
2021-03-04
Operator Address
bva1t42gtf6hawqgpmdpjzmvlzvmlttlqtkvlmgjxt
Self Delegate Address
bnb1weh5t6q0qf0nxpnj6flru9g9gdw9wkzm9hrtqn
Consensus Address
0x70F657164e5b75689b64B7fd1fA275F334f28e18
Fee Address
0x5CF5d69852151952b1b1faF04d9B6140dAe30aFD

QN_bffccb7aa66044ee96fc6c817aae0052
perate Since
2024-04-18
Type
Cabinet
Website
https://bscscan.com/
Self Delegation
2,253.6828367024464 BNB
Delegators
36
Operator Address
0x0C5c5472...86f66D3A54

Consensus Address
0x502aECFE...FeD0Fe16a0

Vote Address
0xb15df589...ef5b8054ab

Identity
0xd8830be9...12289cd7af

{
"validatorSrcAddr": "bva1t42gtf6hawqgpmdpjzmvlzvmlttlqtkvlmgjxt",
"validatorDstAddr": "0x0c5c547215c6516603c3de9525abef86f66d3a54",
"delegatorAddr": "0x689f25d1292daf08988941ae1ce509ba4d18c1cd",
"refundAddr": "bnb1weh5t6q0qf0nxpnj6flru9g9gdw9wkzm9hrtqn",
"amount": {
"amount": 4995000000000,
"denom": "BNB"
}
}
/**
*Submitted for verification at BscTrace on 2024-06-07
*/

TheManager73 · 2024-08-15T17:22:38Z

}
0x7777772e636f696e626173652e636f6d2077616e747320796f7520746f207369676e20696e207769746820796f757220457468657265756d206163636f756e743a0a3078463534626236616431393142443235643135433930363536656566646641333430646345423737630a0a506c65617365207369676e2074686973206d65737361676520746f20636f6e6669726d206f776e657273686970206f6620746869732077616c6c65742e0a0a5552493a2068747470733a2f2f7777772e636f696e626173652e636f6d2f6f6e636861696e2d7665726966790a56657273696f6e3a20310a436861696e2049443a20383435330a4e6f6e63653a2070737a7069736634577a3876787337680a4973737565642041743a20323032342d30372d30395430383a32363a32365a0a45787069726174696f6e2054696d653a20323032342d30372d30395430383a33313a32365a",
"0xF54bb6ad191BD25d15C90656eefdfA340dcEB77c"
]

]
organizations/40166415-efac-48a0-899c-33873249eb95/apiKeys/d56ef5db-01c4-45dc-b1ce-ab15da785d5f

https://bscscan.com/address/0x0000000000000000000000000000000000001000#readContract#F2

{
"description": {
"moniker": "BscScan",
"identity": "",
"website": "https://bscscan.com",
"details": "Your Gateway to the Binance Smart Chain Network. BscScan is the leading BSC Block Chain Explorer and one of the earliest independent project built and developed for the Binance Smart Chain"
},
"validatorAddress": "bva1t42gtf6hawqgpmdpjzmvlzvmlttlqtkvlmgjxt",
"commissionRate": 10000000,
"sideChainId": "bsc",
"sideFeeAddr": "0x5cf5d69852151952b1b1faf04d9b6140dae30afd"
}

{
"description": {
"moniker": "BscScan",
"identity": "",
"website": "https://bscscan.com",
"details": "Your Gateway to the Binance Smart Chain Network. BscScan is the leading BSC Block Chain Explorer and one of the earliest independent project built and developed for the Binance Smart Chain"
},
"commission": {
"rate": 25000000,
"maxRate": 90000000,
"maxChangeRate": 80000000,
"updateTimeInMs": 0
},
"delegatorAddr": "bnb1weh5t6q0qf0nxpnj6flru9g9gdw9wkzm9hrtqn",
"validatorAddr": "bva1t42gtf6hawqgpmdpjzmvlzvmlttlqtkvlmgjxt",
"delegation": {
"amount": 5000000000000,
"denom": "BNB"
},
"sideChainId": "bsc",
"sideConsAddr": "0x70f657164e5b75689b64b7fd1fa275f334f28e18",
"sideFeeAddr": "0x5cf5d69852151952b1b1faf04d9b6140dae30afd"
}

hasti0073

**```

j75689 and others added 17 commits November 29, 2023 17:20

feat: bc fusion hardfork implementation (#358)

065b547

fix: panic issue when doing refundStake and closeCorssChainChannel (#362

2b34b1a

) * fix: handleMsgSideChainUndelegate should not pass prefixCtx * fix: nil pointer when doing ibc method in endblock

fix: add logs to sunset fork events and immediate sidechain undelegat…

fdcabf6

…ion (#364)

fix: revert immediate sidechain undelegation and handle undelegation …

9e0aa25

…in endblock (#365)

fix: disable ClaimMsg after FinalSunsetFork (#366)

555f527

fix: add missing register for new msg (#368)

7db666f

fix: error within CreateRawIBCPackageByIdWithFee (#369)

19fff98

fix: decimal for BCFusionStopGovThreshold (#370)

9588e44

fix: panic when totally unbound the validator in voting period (#371)

166bea3

fix: add missing event (#372)

3536cdb

fix: wrong json tag (#373)

08fd2ca

fix: add missing tag of relayer fee in `handleMsgSideChainStakeMigrat…

d893e87

…ion` (#376)

fix: reset context every time in refund loop (#378)

14aa8ec

fix: do not charge relayerFee for auto cross undelegate after SecondS…

80c11fe

…unsetFork (#379) * fix: do not charge relayerFee for auto cross undelegate after SecondSunsetFork * fix: FeeCalculator

chore: add logs for processed refunding count (#380)

f5678f8

fix: close mirror, mirrorSync channel after FinalSunsetFork (#382)

db42125

forcodedancing reviewed Jan 24, 2024

View reviewed changes

j75689 added 3 commits January 26, 2024 14:17

fix: disable MsgEditSideChainValidator after FirstSunsetFork and refi…

190730d

…ne codes (#383)

fix: change StakeMigrationRelayFee to 0.002BNB (#384)

dc761f4

fix: appHash mismatch causes by channelsMap (#385)

f8fc0b8

unclezoro approved these changes Feb 26, 2024

View reviewed changes

unclezoro merged commit 46d2616 into develop Feb 26, 2024
2 checks passed

unclezoro mentioned this pull request Feb 26, 2024

release: prepare for the release v0.26.7 #387

Merged

5 tasks

j75689 mentioned this pull request Feb 26, 2024

feat: adapted to bep-333 (BC-Fusion) bnb-chain/go-sdk#189

Merged

namnlm approved these changes May 5, 2024

View reviewed changes

TheManager73 reviewed Aug 15, 2024

View reviewed changes

hasti0073 reviewed Sep 18, 2024

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: implement BEP-333(BNB Chain Fusion) #381

feat: implement BEP-333(BNB Chain Fusion) #381

j75689 commented Jan 15, 2024 •

edited

Loading

codecov-commenter commented Jan 15, 2024 •

edited

Loading

forcodedancing Jan 24, 2024

j75689 Jan 26, 2024

j75689 Jan 26, 2024 •

edited

Loading

forcodedancing Jan 24, 2024

j75689 Jan 26, 2024

forcodedancing Jan 24, 2024

j75689 Jan 26, 2024

forcodedancing Jan 24, 2024

j75689 Jan 26, 2024

TheManager73 left a comment

TheManager73 commented Aug 15, 2024

hasti0073 left a comment

feat: implement BEP-333(BNB Chain Fusion) #381

feat: implement BEP-333(BNB Chain Fusion) #381

Conversation

j75689 commented Jan 15, 2024 • edited Loading

Description

Rationale

Example

Notable Changes

codecov-commenter commented Jan 15, 2024 • edited Loading

Codecov Report

Choose a reason for hiding this comment

Choose a reason for hiding this comment

j75689 Jan 26, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

TheManager73 left a comment

Choose a reason for hiding this comment

TheManager73 commented Aug 15, 2024

hasti0073 left a comment

Choose a reason for hiding this comment

j75689 commented Jan 15, 2024 •

edited

Loading

codecov-commenter commented Jan 15, 2024 •

edited

Loading

j75689 Jan 26, 2024 •

edited

Loading