Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bluepill doesn't honor stop_signals delays #31

Open
guss77 opened this issue Apr 7, 2015 · 0 comments
Open

Bluepill doesn't honor stop_signals delays #31

guss77 opened this issue Apr 7, 2015 · 0 comments

Comments

@guss77
Copy link
Contributor

guss77 commented Apr 7, 2015

When using stop signals to set up a multiple signals shutdown process with a delay between signals, then when issuing a stop command Bluepill does the first signal and then just terminates all the processes and exits.

The problem seems to be in process.rb, where if stop_signals are set, it starts a thread to handle the stop_signals, and then immediately calls kill_all_from_journal which basically just sends TERM to all processes.

A correct implementation of this is required to handle graceful shutdown of processes with a long shutdown process, such as a resque worker.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant