Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

What is the issue with those pid jornals? #3

Open
averell23 opened this issue Dec 12, 2013 · 3 comments
Open

What is the issue with those pid jornals? #3

averell23 opened this issue Dec 12, 2013 · 3 comments

Comments

@averell23
Copy link

Bluepill now uses 'journals' to keep track of past PIDs and kill them on startup (lib/bluepill/process_journal.rb).

The problem is cases like

  • Systems goes down for whatever reason, the journal still being around
  • System comes back up, and tries to restart the service
  • The pids in the journal may now belong to system processes
  • Since bluepill doesn't run w/ root privileges for me, it bails out at this point

Pids may also overflow and get reused during normal operations. In short, a pid is not unique to a process forever.

I appreciate what this feature is trying to solve. Still, I don't appreciate having a software on my production setup that tries to randomly kill processes after a reboot.

@iancoffey
Copy link
Member

Yeah, agreed. Im going to review the journal setup and see about improving the idea.

@akzhan
Copy link
Contributor

akzhan commented Jan 21, 2014

Moeve journals to /var/run or something like it? Any renewed/reboot fs.

2014/1/21 Ian Coffey [email protected]

Yeah, agreed. Im going to review the journal setup and see about improving
the idea.


Reply to this email directly or view it on GitHubhttps://github.com//issues/3#issuecomment-32955537
.

@iancoffey
Copy link
Member

Well the journals do live in /var/run...if your options are set or youre root. If youre a user and youre not specifying /var/run you get ~/.bluepill. Bleh.

In the case where base_dir isnt a renewed fs, disabling journaling and throwing a warning seems better.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants