Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Protect not working properly #45

Open
kennumen opened this issue Sep 15, 2012 · 0 comments
Open

Protect not working properly #45

kennumen opened this issue Sep 15, 2012 · 0 comments

Comments

@kennumen
Copy link
Collaborator

It correctly sets "m_targetType = TARGET_THREATEN;" over in GetCombatTarget(), and switches targets properly, but the TARGET_THREATEN flag isn't used anywhere. I understand why it's unnecessary for tanks (because they will always have ORDERS_TANK flag active) but it really should be used/obeyed to get aggro off a healer or other protect target by casting high-aggro spells by non-tanks.

More difficult to do on classes that never tank (identify high aggro skills and put them in a special tanking/aggro section), but should be reasonably easy on the tank classes (which is 4/10).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant