Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(yafti): Prepare the module for future yafti refactor #168

Open
fiftydinar opened this issue Mar 19, 2024 · 3 comments
Open

chore(yafti): Prepare the module for future yafti refactor #168

fiftydinar opened this issue Mar 19, 2024 · 3 comments
Labels
priority: low Might be supported or done in the future, but won't be prioritised type: discussion Questions, proposals and info that requires discussion.

Comments

@fiftydinar
Copy link
Collaborator

It is not known if current yafti.yml config format will remain functional in the new refactored version of yafti.
It is not known if yafti will change it's function dramatically, instead of being the setup, being the configurator only.
It is also not known how will the new yafti look visually in terms of UI.

But it is known that there is the intention & effort in doing the refactor, which I found out in Universal Blue discord channel.

So this issue will be updated to cover further findings in this regard, to clarify if our action is needed or not.

@xynydev
Copy link
Member

xynydev commented Mar 19, 2024

The legacy custom-flatpaks option should be removed from the module. It might be wise to move the yafti install to bling, and make the configuration the users job.

@fiftydinar
Copy link
Collaborator Author

The legacy custom-flatpaks option should be removed from the module. It might be wise to move the yafti install to bling, and make the configuration the users job.

I agree with this.

yafti is in the similar category like ublue-update, where it's the Universal Blue only component, which has potential to drastically change over time, requiring us to constantly update the template config.
So it is indeed wise to make this the user job.

@fiftydinar fiftydinar added type: discussion Questions, proposals and info that requires discussion. priority: low Might be supported or done in the future, but won't be prioritised labels Mar 19, 2024
@fiftydinar
Copy link
Collaborator Author

fiftydinar commented May 9, 2024

It would be good to freeze yafti version to 0.8.0 in module until we test new yafti.

Change should be simple, like this:

pip install --prefix=/usr yafti==0.8.0

Edit: here's the PR
#220

Edit2: done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority: low Might be supported or done in the future, but won't be prioritised type: discussion Questions, proposals and info that requires discussion.
Projects
None yet
Development

No branches or pull requests

2 participants