fix s3cfg_path handling when HOME does not exists #172
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
following exception occurs when enviromental variable HOME is not set in s3_keys_from_s3cfg method Exception UnboundLocalError: local variable 's3cfg_path' referenced before assignment exception is triggered by accessing the dictionary key HOME which does not exist, resulting in s3cfg_path is not set. but then, the variable s3cfg_path is sadly used in the Exception handling. this patch fixes this by checking the presence of HOME environmental variable. if not found, method returns None
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
following exception occurs when enviromental variable HOME is not set in s3_keys_from_s3cfg method
Exception UnboundLocalError: local variable 's3cfg_path' referenced before assignment
exception is triggered by accessing the dictionary key HOME which does not exist, resulting in s3cfg_path is not set. but then, the variable s3cfg_path is sadly used in the Exception handling.
this patch fixes this by checking the presence of HOME environmental variable. if not found, method returns None